[IMP] base_geoengine: align with the consolidated module version#6
Merged
Merged
Conversation
Replace base_geoengine in the migration branch with the version from the 19.0-mig-base_geoengine-consolidated branch, which carries the maintained/cleaned-up module while this branch keeps the satellite addons (geoengine_tools, geoengine_swisstopo, geoengine_drone_ortho…). Notable changes pulled in from the consolidated module: - security: enforce record rules on indirect geo sub-queries - Odoo 19: use group_ids instead of groups_id on res.users - refactor geo library loading to dynamic imports; slimmer vendored libs - renderer cleanups and added model tests Satellite modules are left untouched; the renderer extension points they patch (setupControls, createHtmlControl, addSelectedClassToButton, remove*Interaction, registerInteraction, this.format, createDrawControl) all still exist in the consolidated renderer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
base_geoengineon this branch lagged behind the maintained version kept on19.0-mig-base_geoengine-consolidated. This PR brings the consolidated module in, while the branch keeps the satellite addons (geoengine_tools,geoengine_swisstopo,geoengine_drone_ortho, …).What
The
base_geoengine/directory is replaced wholesale by the version from19.0-mig-base_geoengine-consolidated(≈ 332 insertions / 5632 deletions — most of the deletions are slimmer vendored libs). Notable functional changes pulled in:group_idsinstead ofgroups_idonres.usersSatellite modules are untouched. The renderer extension points they patch (
setupControls,createHtmlControl,addSelectedClassToButton,remove*Interaction,registerInteraction,this.format,createDrawControl) all still exist in the consolidated renderer.Verification
pre-commit run --all-fileslocally: all hooks pass exceptdebug-statementsandpylint_odoo, which only fail under my local Python 3.9 becausebase_geoengine/expressions.pyuses amatchstatement (Python 3.10+). CI runs Python 3.11 (py_compileunder 3.12 confirms the file is valid), so both pass there.Note
🤖 Generated with Claude Code