Repository navigation
Report which QLever built each index - #921
Merged
Merged
Conversation
- Add an optional generic engine ({ name, version }) to ImportSuccessful
- Read QLever’s git-hash from meta-data.json, for fresh and cached indexes
- For a cached index, report the QLever that built it, not the one serving it
- Replace ResolvedDistribution’s importedFrom, importDuration and tripleCount with imported
- Pass that object to ProgressReporter.distributionSelected, now with the import engine
- Print the engine in the console reporter: “Imported <dump> into QLever 9352d0 (…)”
BREAKING CHANGE: ResolvedDistribution takes an ImportDetails object
({ from, duration, tripleCount?, engine? }) as its third argument instead of
importedFrom, importDuration and tripleCount, and exposes it as imported.
ProgressReporter.distributionSelected(dataset, distribution, imported?)
receives the same object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #908
A pipeline log now says which QLever built each imported index:
@lde/sparql-importer:ImportSuccessfulgets an optional, genericengine: { name, version }.versionis the engine’s own identifier: a release number, or a commit hash for an engine without releases.@lde/sparql-qlever: the importer reads thegit-hashfrommeta-data.json, both after a fresh build and on a cache hit. For a cached index it reports the QLever that built the index, which can be older than the one serving it. The integration test against the real image asserts the hash.@lde/pipeline(breaking):ResolvedDistributionandProgressReporter.distributionSelectedtake oneimported: { from, duration, tripleCount?, engine? }object instead of the positionalimportedFrom,importDurationandtripleCount. The DKG’s and Linked Open Limburg’s reporters don’t implementdistributionSelected, so neither needs a change.@lde/pipeline-console-reporter: prints the engine.The pipeline’s statement coverage threshold drops from 96.74 to 96.73. The uncovered lines are the same as on
main; the change removes covered statements, which shifts the ratio.