Skip to content

Fix urlscan pagination with json.Number sort values#173

Open
Imkznan wants to merge 1 commit into
lc:masterfrom
Imkznan:fix-urlscan-pagination
Open

Fix urlscan pagination with json.Number sort values#173
Imkznan wants to merge 1 commit into
lc:masterfrom
Imkznan:fix-urlscan-pagination

Conversation

@Imkznan

@Imkznan Imkznan commented Jul 17, 2026

Copy link
Copy Markdown

Description

Fix urlscan provider pagination failure caused by mixed types in the sort field.

The urlscan API returns sort values containing both json.Number and string types. The previous parseSort() implementation only handled string, causing json.Number values to be ignored.

This produced an incomplete search_after parameter and caused HTTP 400 errors when fetching the next page of results.

Fix

Update parseSort() to handle json.Number values and preserve the complete search_after parameter.

Before:

search_after=<uuid>

After:

search_after=<timestamp>,<uuid>

Testing

Tested with:

gau example.com

Before:

  • First page fetched successfully.
  • Second page failed with HTTP 400.

After:

  • Pagination works correctly and additional pages are fetched successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant