Repository navigation
feat(snippets): add flag override snippets for the Java SDK - #718
Draft
kinyoklion wants to merge 2 commits into
Draft
kinyoklion wants to merge 2 commits into
kinyoklion wants to merge 2 commits into
Conversation
Generated-by: termag
Member
Author
|
bugbot review |
…ample Generated-by: termag
Member
Author
|
bugbot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7cd5c84. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileOverrides.source(), the source options (two files,IGNOREduplicate key handling, and watching), and a check ofisOverrideAffected()on the evaluation reason.jvmvalidator resolves the newest 7.x release (7.17.4 today), so the three new snippets fail to compile (cannot find symbol: FileOverrides) until a release with flag overrides ships. Do not merge before then.java-syntax-onlyscaffold provides and the shared override file examples in JSON and YAML; every flag evaluated to the documented value and reason kind. The existingdatasaving/file-bootstrapsnippet passes the stock validator.Opened from termag
SDK-3494
Note
Overview
Adds three new Java server SDK reference snippets under
features/overridesto support upcoming “Flag overrides” docs.The snippets show wiring
FileOverrides.source()intoLDConfigviaComponents.dataSystem().defaultMode().overrides(...), including a basic single-file example, an advanced builder with multiple paths,DuplicateKeysHandling.IGNORE, andChangeDetection.WATCHING, and detecting overrides at evaluation time withdetail.getReason().isOverrideAffected().Each snippet uses the existing
java-syntax-onlyscaffold for validation. They depend onFileOverridesAPIs that are not yet in a released 7.x artifact, so CI compilation will fail until a release that includes flag overrides ships (as noted in the PR description).Reviewed by Cursor Bugbot for commit 7cd5c84. Bugbot is set up for automated code reviews on this repo. Configure here.