ci: replace reusable workflow with gh-actions composite actions#384
Merged
kinyoklion merged 2 commits intomainfrom Apr 16, 2026
Merged
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
claude-review — Issues FoundThe claude-review security scan found issues on commit |
joker23
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
N/A — CI-only change, no application code modified.
Related issues
A similar change was made in
launchdarkly/hello-node-typescriptto replacecommon-workflowsreusable workflow usage.Describe the solution you've provided
Replaces the reusable workflow reference (
launchdarkly/gh-actions/.github/workflows/dependency-scan.yml@main) with direct usage of the two composite actions fromlaunchdarkly/gh-actions/actions/dependency-scan/:generate-sbom— generates the SBOM fornodejsevaluate-policy— evaluates the SBOM against the license policyThis aligns with how other SDK repos (
js-client-sdk,js-core,openfeature-node-server, etc.) already configure their dependency scan workflows.Describe alternatives you've considered
None — this is a direct migration to the recommended action pattern.
Additional context
The previous reusable workflow path (
gh-actions/.github/workflows/dependency-scan.yml) does not exist in thegh-actionsrepo, so the old workflow was non-functional.Human review checklist
generate-nodejs-sbom→evaluate-policy) matches the standard org patternLink to Devin session: https://app.devin.ai/sessions/2783d2578c67461aa0af3b814ea886b2
Requested by: @kinyoklion
Note
Low Risk
CI-only workflow change; main risk is breaking dependency scanning if the new jobs/artifact pattern are misconfigured.
Overview
Updates the
Dependency ScanGitHub Actions workflow to stop calling thelaunchdarkly/gh-actionsreusable workflow and instead run two explicit jobs.The new flow generates a Node.js SBOM via
actions/dependency-scan/generate-sbom@main, then gates on a follow-upevaluate-policyjob that runsactions/dependency-scan/evaluate-policy@mainagainst the producedbom-*artifacts.Reviewed by Cursor Bugbot for commit e3b9b7c. Bugbot is set up for automated code reviews on this repo. Configure here.