fix(build): make typecheck matches CI (mypy packages/*/src) - #85
Draft
apucacao wants to merge 1 commit into
Draft
Conversation
`make typecheck` ran `uv run mypy .`, which walks every package's tests/conftest.py. mypy treats them as duplicate top-level `conftest` modules and aborts before checking anything, so the documented local command fails on a clean checkout while CI stays green. CI type-checks `packages/*/src`. Point the Makefile target at the same paths so `make typecheck` matches CI and passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
make typecheckrunsuv run mypy ., which walks every package'stests/conftest.py. mypy sees them as duplicate top-levelconftestmodules and aborts before checking anything:So the documented local command fails on a clean checkout, even though CI is green.
Fix
CI type-checks
packages/*/src(.github/workflows/ci.yml). Point the Makefile target at the same paths somake typecheckmatches CI and passes.uv run mypy packages/*/srcreports success on 45 source files.Separate, standalone fix, ahead of the grounded-judge-context PR so that one can meet a clean
make typecheckgate.