Repository navigation
chore: Remove unused dependencies - #74
Merged
Merged
Conversation
jsonbailey
marked this pull request as ready for review
November 4, 2026 23:54
joker23
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove five entries from the docs dependency group that were copied from the python-server-sdk dependency list. Nothing in this repo imports them.
expiringdict,pyrfc3339,semver,urllib3: not imported byld_openfeature, tests, ordocs/conf.py. They are runtime dependencies oflaunchdarkly-server-sdk, and the docs build (make docsand.readthedocs.yml) runspoetry install --with docs, which installs the main dependencies too. So they still arrive transitively.jsonpickle: not imported anywhere here and not required by any dependency.Verified with
make test,make lint, andmake docs.Note
Overview
Removes five unused packages from the optional
[tool.poetry.group.docs.dependencies]list inpyproject.toml:expiringdict,pyrfc3339,jsonpickle,semver, andurllib3.They were redundant with the main SDK stack—nothing in this repo imports them directly, and the docs install path still pulls in what LaunchDarkly needs via
launchdarkly-server-sdkwhen you runpoetry install --with docs. The docs group now only declares Sphinx, sphinx-rtd-theme, and jinja2.Reviewed by Cursor Bugbot for commit 95ee23c. Bugbot is set up for automated code reviews on this repo. Configure here.