Skip to content

chore: Remove unused dependencies - #74

Merged
jsonbailey merged 1 commit into
mainfrom
jb/sdk-3466/remove-unused-deps
Nov 5, 2026
Merged

jsonbailey merged 1 commit into
mainfrom
jb/sdk-3466/remove-unused-deps

Conversation

@jsonbailey

@jsonbailey jsonbailey commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Remove five entries from the docs dependency group that were copied from the python-server-sdk dependency list. Nothing in this repo imports them.

  • expiringdict, pyrfc3339, semver, urllib3: not imported by ld_openfeature, tests, or docs/conf.py. They are runtime dependencies of launchdarkly-server-sdk, and the docs build (make docs and .readthedocs.yml) runs poetry install --with docs, which installs the main dependencies too. So they still arrive transitively.
  • jsonpickle: not imported anywhere here and not required by any dependency.

Verified with make test, make lint, and make docs.


Note

Overview
Removes five unused packages from the optional [tool.poetry.group.docs.dependencies] list in pyproject.toml: expiringdict, pyrfc3339, jsonpickle, semver, and urllib3.

They were redundant with the main SDK stack—nothing in this repo imports them directly, and the docs install path still pulls in what LaunchDarkly needs via launchdarkly-server-sdk when you run poetry install --with docs. The docs group now only declares Sphinx, sphinx-rtd-theme, and jinja2.

Reviewed by Cursor Bugbot for commit 95ee23c. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey
jsonbailey marked this pull request as ready for review November 4, 2026 23:54
@jsonbailey
jsonbailey requested a review from a team as a code owner November 4, 2026 23:54
@jsonbailey
jsonbailey merged commit a6f8092 into main Nov 5, 2026
26 of 27 checks passed
@jsonbailey
jsonbailey deleted the jb/sdk-3466/remove-unused-deps branch November 5, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants