Repository navigation
ci: Run contract tests with the shared action and an authenticated token - #120
Open
kinyoklion wants to merge 1 commit into
Open
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
main, thelinux (8)job of Quality control checks fails at theContract testsstep withUnable to find a release matching 'v2'. CI ranmake contract-tests, which downloads thesse-contract-testsharness without authentication. GitHub rate-limits unauthenticated release lookups, and the downloader reports a rate-limited lookup as a missing release.This change adds a local composite action,
.github/actions/contract-tests, modelled on the one inswift-eventsource. It builds and starts the test service using the existing make targets, then runs the harness throughlaunchdarkly/gh-actions/actions/contract-tests@contract-tests-v1withtoken: ${{ secrets.GITHUB_TOKEN }}. TheContract testsstep inci.ymlnow uses that action. The make targets stay as they were for local use.How to test: the
linuxmatrix jobs on this PR should download the harness and run the contract tests.Limitations: running the harness with this token locally downloaded
sse-contract-testsv2.32.0. I could not build the test service on my machine because a Gradle dependency would not resolve there, so CI on this PR is the end-to-end check.Link to Devin session: https://app.devin.ai/sessions/fe4a81e87871412a99d2eed85302fe33
Open in Devin Desktop: https://app.devin.ai/desktop/session/fe4a81e87871412a99d2eed85302fe33?variant=devin
Note
Overview
Fixes flaky CI where the contract test step failed with "Unable to find a release matching 'v2'" because unauthenticated GitHub API lookups for
sse-contract-testswere rate-limited.Adds a local composite action (
.github/actions/contract-tests) that runsmake build-contract-testsandmake start-contract-test-service-bg, then invokeslaunchdarkly/gh-actions/actions/contract-tests@contract-tests-v1withtokenfrom the workflow, v2 harness settings, port8000, and persistence tests off. The LinuxContract testsstep in CI nowusesthat action withsecrets.GITHUB_TOKENinstead ofmake contract-testsalone, so the harness download is authenticated while existing make targets stay for local use.Reviewed by Cursor Bugbot for commit 1d6e4d1. Bugbot is set up for automated code reviews on this repo. Configure here.