Repository navigation
Conversation
joker23
marked this pull request as ready for review
November 2, 2026 23:26
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
@launchdarkly/js-client-sdk size report |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
run-custom-eventsource-examplejob insdk/browserfailed on main withCould not resolve '@launchdarkly/js-client-sdk/fetch-eventsource'.The example was added in #2139 with an exact pin of
4.13.1. The release in #2140 bumped the workspace to4.14.0, so Yarn stopped linking the workspace package and fetched4.13.1from npm. That version has no./fetch-eventsourcesubpath.This PR bumps the pin to
4.14.0. The example is already listed in the release-pleaseextra-filesforpackages/sdk/browser, so later releases keep it in sync.Note
Overview
Updates the custom EventSource example’s dependency pin on
@launchdarkly/js-client-sdkfrom 4.13.1 to 4.14.0 so it matches the workspace browser SDK after the recent release.That fixes CI for
run-custom-eventsource-example, which was resolving 4.13.1 from npm (not the workspace) and failing on the missing@launchdarkly/js-client-sdk/fetch-eventsourcesubpath introduced in the current SDK.Reviewed by Cursor Bugbot for commit 882f8aa. Bugbot is set up for automated code reviews on this repo. Configure here.