Repository navigation
Conversation
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
force-pushed
the
skz/SDK-3426/vue-rn-ws-conform
branch
2 times, most recently
from
October 30, 2026 22:24
13f0e39 to
7247f61
Compare
joker23
force-pushed
the
skz/SDK-3426/vue-rn-ws-conform
branch
2 times, most recently
from
November 2, 2026 14:40
0d093cc to
6739dae
Compare
joker23
force-pushed
the
skz/SDK-3426/vue-rn-ws-conform
branch
from
November 2, 2026 15:10
6739dae to
30ff88a
Compare
joker23
force-pushed
the
skz/SDK-3426/vue-rn-ws-conform
branch
from
November 2, 2026 15:15
30ff88a to
8f673e3
Compare
joker23
marked this pull request as ready for review
November 2, 2026 16:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capabilitiesandonConnectionChangeoptions to the shared base. Defaults keep the browser and React behavior unchanged.disconnect(). React Native already did this. The browser and React entities gain it.Note
Overview
Vue and React Native contract-test harness WebSockets are refactored to extend the shared
TestHarnessWebSocketbase (like browser/React), deleting their local connect/reconnect, message dispatch, and capability handling. Each SDK subclass only supplies its capability list and implementscreateClient/getCommandHandler/deleteClientagainst localClientEntityinstances.The shared base gains an optional
onConnectionChangehook (used by React Native’s constructor) and exportsTestHarnessWebSocketOptions. Reconnect behavior is aligned sodisconnect()sets intentional close and pending reconnect timers are skipped—matching what React Native already did and what browser/React entities pick up via the base.Reviewed by Cursor Bugbot for commit 8f673e3. Bugbot is set up for automated code reviews on this repo. Configure here.