Conversation
The "Public Exports" block had drifted from `src/index.ts` in both directions: it listed a `./tracking.js` re-export that `index.ts` does not have, and omitted the `content.js` set, the judge helpers, several `types.js` names, and the skills option and mode types. It is now generated from `index.ts` verbatim and in its order, with a note saying so, because a hand-curated copy of a 20-statement barrel drifts again. Pitfall 6 still described the pre-`/proc/self/fd` world — that `SUPPORTS_DIR_FD` is `false` and the swap-race tests are therefore skipped with the exposure "real and recorded, not fixed". Since 0a15b10 that is wrong on Linux: `SUPPORTS_PROC_FD` addressing closes the window there and the tests run. Records the two things a reader needs to keep straight — that the identity re-check is the macOS floor only and must not be attempted on the fast path, and that a green macOS run says nothing, because all ten of those tests execute on Linux CI alone. Also records the third test hook, the `vi.mock` of `mkdir`/`open` the root-swap races fire from, which is deliberately not part of `fsOps`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
XieX
force-pushed
the
xie/skills-12-test-integrity
branch
from
September 18, 2026 19:49
b3ce5e4 to
f74c412
Compare
XieX
force-pushed
the
xie/skills-13-docs-closeout
branch
from
September 18, 2026 19:49
274ac63 to
49db83b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out the documentation remainder of the Agent Skills code review, on top of the four remediation PRs (#61–#64).
agents.md"Public Exports"The block had drifted from
src/index.tsin both directions — it listed a./tracking.jsre-export thatindex.tsdoes not have, and omitted the wholecontent.jsset, the judge helpers, a dozentypes.jsnames, and the skills option/mode types (FDv2Mode,FDv2SkillStoreOptions,StoreDiagnostics,WatchSkillsOptions).It is now generated from
index.tsverbatim and in its order, with a note saying so. A hand-curated copy of a 20-statement barrel drifts again; this is the second time it has.Pitfall 6 — the platform bound
The closing sentence still described the pre-
/proc/self/fdworld: thatSUPPORTS_DIR_FDisfalse, the swap-race tests are therefore skipped, and the exposure is "real and recorded, not fixed". Since0a15b10that is wrong on Linux —SUPPORTS_PROC_FDaddressing closes the window there and the tests run.Records the two things a reader has to keep straight:
(dev, ino)identity re-check is the macOS floor only and must not be attempted on the fast path, becauselstatof/proc/self/fd/<fd>reports procfs's magic symlink rather than the directory.Also records the third test hook — the
vi.mockofmkdir/openthat the root-swap races fire from — which is deliberately not part offsOps, because those races have to fire before the root is pinned.Verification
tsc --noEmitbiome checkvitest run(macOS)vitest run(Linux CI, #64)Docs-only; no source change. The Linux figure is the one that matters for the swap-race and
/proc/self/fdwork in #63/#64 — all ten of the tests that skip on macOS pass there.🤖 Generated with Claude Code, reviewed by @XieX
Note
Overview
Updates
agents.mdonly—no runtime changes.Public Exports: The
src/index.tsbarrel listing is replaced with a verbatim, ordered copy and a warning not to hand-edit it. That fixes drift (e.g. a bogus./tracking.jsexport) and adds missing surface such ascontent.js, judge helpers, expandedtypes.jsnames, and skills-related option types.Pitfall 6: Documents a third test hook (
vi.mockonmkdir/openfor pre-pin root-swap races), kept outsidefsOpsso “no filesystem operation attempted” stays meaningful. Corrects the platform-bound narrative: Linux’s/proc/self/fdfast path (SUPPORTS_PROC_FD) runs swap-race tests there;(dev, ino)is macOS-only; passing tests on macOS does not prove those races are covered.Reviewed by Cursor Bugbot for commit 49db83b. Bugbot is set up for automated code reviews on this repo. Configure here.