Skip to content

fix: Make TestData valueForAll return its value when targeting is off #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keelerm84 merged 1 commit into from
Nov 6, 2026
+22 −1
Merged

fix: Make TestData valueForAll return its value when targeting is off #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/TestData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ public FlagBuilder variationForAll(int variationIndex) {
public FlagBuilder valueForAll(LDValue value) {
variations.clear();
variations.add(value);
return variationForAll(0);
return variationForAll(0).offVariation(0);
}

/**
Expand Down
12 changes: 12 additions & 0 deletions lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/integrations/TestDataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,18 @@ public void flagConfigSimpleBoolean() throws Exception {
);
}

@Test
public void valueForAllSetsOffVariationToTheValue() throws Exception {
verifyFlag(
f -> f.valueForAll(LDValue.of("x")),
fb -> fb.on(true).variations("x").offVariation(0).fallthroughVariation(0)
);
verifyFlag(
f -> f.valueForAll(LDValue.of("x")).on(false),
fb -> fb.on(false).variations("x").offVariation(0).fallthroughVariation(0)
);
}

@Test
public void usingBooleanConfigMethodsForcesFlagToBeBoolean() throws Exception {
Function<ModelBuilders.FlagBuilder, ModelBuilders.FlagBuilder> expectedBooleanFlag = fb ->
Expand Down
9 changes: 9 additions & 0 deletions ...server/src/test/java/com/launchdarkly/sdk/server/integrations/TestDataWithClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ public void deletesFlag() throws Exception {
}
}

@Test
public void valueForAllReturnsValueWhenTargetingIsOff() throws Exception {
td.update(td.flag("flag").valueForAll(LDValue.of("x")).on(false));

try (LDClient client = new LDClient(SDK_KEY, config)) {
assertThat(client.stringVariation("flag", LDContext.create("user"), "default"), equalTo("x"));
}
}

@Test
public void usesTargets() throws Exception {
td.update(td.flag("flag").fallthroughVariation(false).variationForUser("user1", true));
Expand Down
Loading