Repository navigation
chore: float JUnit constraints within their current major - #19
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
@cursor review |
Contributor
Author
|
Closing: junit 5.14.4 works fine, so this loosening was unnecessary. Only the LaunchDarkly SDK/provider packages should float within their major; other dependencies stay pinned unless a bump is required to keep building. The SDK constraints in this repo already resolve to the latest releases, so no change is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly
sdk-examplessweep: the only exact library pin left in this example was JUnit, so it now uses a within-major range like the LaunchDarkly/OpenFeature deps beside it.junit-jupiter-api/junit-jupiter-engine:5.14.4→[5.14.4,6.0.0)(floor preserved; resolves to 5.14.4, still the latest 5.x).launchdarkly-java-server-sdk [7.0.0, 8.0.0),launchdarkly-openfeature-serverprovider [1.0.0, 2.0.0)anddev.openfeature:sdk [1.2.0,2.0.0)already float and resolve to the latest releases (7.17.1 / 1.2.1 / 1.22.1).actions/checkout@v4,actions/setup-java@v4,release-secrets-v1.1.0andverify-hello-app-v2.0.0. Those bumps are deliberately not re-proposed here — reopen chore: update CI actions to latest versions #18 if they were wanted.Implementation details
Resolved versions (
./gradlew dependencies): provider[1.0.0, 2.0.0)→ 1.2.1,launchdarkly-java-server-sdk [7.0.0, 8.0.0)→ 7.17.1 (latest 7.x; 7.17.1 published since the last sweep and picked up with no manifest change),dev.openfeature:sdk [1.2.0,2.0.0)→ 1.22.1, JUnit[5.14.4,6.0.0)→ 5.14.4. There is no committed lockfile.Not floated, deliberately: the
com.gradleup.shadowplugin (8.3.11, latest is 9.6.1 — a major bump and build tooling, not a library), the Gradle wrapper (8.14.5), and the GitHub Actions pins.Deprecated APIs:
compileJavawith-Xlint:deprecation,removal -Werroragainst the resolved classpath produced no warnings.Testing on Java 17 (Maven Central 429s this VM, so resolution went through the
maven-central.storage-download.googleapis.commirror via an init script):./gradlew clean buildsucceeded (testisNO-SOURCE— the example has no test sources), andjava -jar build/libs/hello-openfeature-java-server-1.0-SNAPSHOT-all.jarwith thehello-appsserver key andLAUNCHDARKLY_FLAG_KEY=hello-booleanprintedSDK successfully initialized!andThe hello-boolean feature flag evaluates to true.both before and after the change.Link to Devin session: https://app.devin.ai/sessions/e92a7551f18f4ef78173f9e71fd0616a
Open in Devin Desktop: https://app.devin.ai/desktop/session/e92a7551f18f4ef78173f9e71fd0616a?variant=devin