Skip to content

chore: float JUnit constraints within their current major - #19

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789981506-float-junit
Closed

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789981506-float-junit

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Weekly sdk-examples sweep: the only exact library pin left in this example was JUnit, so it now uses a within-major range like the LaunchDarkly/OpenFeature deps beside it.

  • junit-jupiter-api / junit-jupiter-engine: 5.14.4 → [5.14.4,6.0.0) (floor preserved; resolves to 5.14.4, still the latest 5.x).
  • No SDK bump needed: launchdarkly-java-server-sdk [7.0.0, 8.0.0), launchdarkly-openfeature-serverprovider [1.0.0, 2.0.0) and dev.openfeature:sdk [1.2.0,2.0.0) already float and resolve to the latest releases (7.17.1 / 1.2.1 / 1.22.1).
  • No deprecated APIs in use; no source or README changes (documented Java 11 minimum left alone).
  • Heads-up for maintainers: PR chore: update CI actions to latest versions #18 (CI action pins refresh, which also contained this JUnit change) was approved and then closed unmerged on 2026-09-15, so the repo's workflow still uses actions/checkout@v4, actions/setup-java@v4, release-secrets-v1.1.0 and verify-hello-app-v2.0.0. Those bumps are deliberately not re-proposed here — reopen chore: update CI actions to latest versions #18 if they were wanted.
Implementation details

Resolved versions (./gradlew dependencies): provider [1.0.0, 2.0.0) → 1.2.1, launchdarkly-java-server-sdk [7.0.0, 8.0.0) → 7.17.1 (latest 7.x; 7.17.1 published since the last sweep and picked up with no manifest change), dev.openfeature:sdk [1.2.0,2.0.0) → 1.22.1, JUnit [5.14.4,6.0.0) → 5.14.4. There is no committed lockfile.

Not floated, deliberately: the com.gradleup.shadow plugin (8.3.11, latest is 9.6.1 — a major bump and build tooling, not a library), the Gradle wrapper (8.14.5), and the GitHub Actions pins.

Deprecated APIs: compileJava with -Xlint:deprecation,removal -Werror against the resolved classpath produced no warnings.

Testing on Java 17 (Maven Central 429s this VM, so resolution went through the maven-central.storage-download.googleapis.com mirror via an init script): ./gradlew clean build succeeded (test is NO-SOURCE — the example has no test sources), and java -jar build/libs/hello-openfeature-java-server-1.0-SNAPSHOT-all.jar with the hello-apps server key and LAUNCHDARKLY_FLAG_KEY=hello-boolean printed SDK successfully initialized! and The hello-boolean feature flag evaluates to true. both before and after the change.

Link to Devin session: https://app.devin.ai/sessions/e92a7551f18f4ef78173f9e71fd0616a
Open in Devin Desktop: https://app.devin.ai/desktop/session/e92a7551f18f4ef78173f9e71fd0616a?variant=devin

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@cursor review

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Closing: junit 5.14.4 works fine, so this loosening was unnecessary. Only the LaunchDarkly SDK/provider packages should float within their major; other dependencies stay pinned unless a bump is required to keep building. The SDK constraints in this repo already resolve to the latest releases, so no change is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants