ci: bump lower CI matrix to Flutter 3.22.3 / Dart 3.4.4#269
Open
kinyoklion wants to merge 1 commit intomainfrom
Open
ci: bump lower CI matrix to Flutter 3.22.3 / Dart 3.4.4#269kinyoklion wants to merge 1 commit intomainfrom
kinyoklion wants to merge 1 commit intomainfrom
Conversation
Skips the `Null check operator used on a null value` crash in `HostedSource._getAdvisories.readAdvisoriesFromCache` that lands intermittently during `flutter pub get` on Dart 3.4.0-3.4.3. The crash depends on pub advisory cache state, so it surfaces as a flake — passing on rerun roughly half the time. Fixed in Dart SDK 3.4.4 (dart-lang/pub#4312). Flutter 3.22.3 is the first stable release that bundles 3.4.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-test (3.22.0, 3.4.0)matrix row hits a flaky crash inside the Dartpubtool duringflutter pub get:```
Null check operator used on a null value
package:pub/src/source/hosted.dart 760:33
HostedSource._getAdvisories.readAdvisoriesFromCache
package:pub/src/source/hosted.dart 778:12
HostedSource._getAdvisories
```
The crash depends on the state of the pub advisories cache at the moment of resolution, so it presents as a flake — sometimes the run passes, sometimes it fails before our test code executes. Confirmed not in our code (failure is during dependency resolution).
The bug is tracked at dart-lang/pub#4312 and was fixed in Dart SDK 3.4.4 (June 2024). Flutter 3.22.3 (July 2024) is the first stable Flutter release that bundles Dart 3.4.4.
Bumping the lower row from
(3.22.0, 3.4.0)to(3.22.3, 3.4.4)is the minimal change that keeps backward-compat coverage intact while skipping the broken pub binary. The newer row(3.29.3, 3.7.2)was already passing.Test plan
build-test (3.22.3, 3.4.4)andbuild-test (3.29.3, 3.7.2)both pass.Note
Low Risk
Low risk workflow-only change that just updates the CI test matrix tool versions. Main impact is slightly shifting the minimum supported Flutter/Dart versions exercised in CI.
Overview
Updates GitHub Actions CI
build-testmatrix to run the lower-version job on Flutter 3.22.3 / Dart 3.4.4 instead of 3.22.0 / 3.4.0, keeping the newer matrix row unchanged.Reviewed by Cursor Bugbot for commit 5bf3f79. Bugbot is set up for automated code reviews on this repo. Configure here.