Repository navigation
Conversation
…en its payload has a selector
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the RETRY behavior to FDv2 synchronizer orchestration in the Android SDK, following launchdarkly/java-core#252 and launchdarkly/java-core#253. A synchronizer that fails is parked and retried later, instead of being blocked for good.
Parking
next(), a failure to build, or shutting down on its own. The park delay starts at 5 minutes, doubles with each failure up to 1 hour, and has jitter. After a park, the next synchronizer starts after a failover delay of 0.5-1 seconds.Directed fallback
Deadlines
System.nanoTime(), so changes to the system clock don't move them.FDv2DataSourceConditionsis removed.Public API
This extends the public
FDv2SourceResultclass incom.launchdarkly.sdk.android.subsystems, the result type that initializers and synchronizers return. It adds two methods:isResetThresholdMet()returns true if the source met its reset threshold at the time of the result. When a synchronizer returns such a result, the data source resets that synchronizer's park count. Results from the existingchangeSet()andstatus()factory methods return false.withResetThresholdMet()returns a copy of the result withisResetThresholdMet()set to true.FDv2SourceResultis part of the early access FDv2 data system. It now carries the same note as the other early access types, saying that it is not stable and not subject to backwards compatibility guarantees or semantic versioning.Not included
FailureClassfrom a newer java-sdk-internal.Retry-After, and reading the TTL from the response. Every directive uses the 1-hour default.ConnectivityManagertreats INTERRUPTED with no error as a successful connection. Some of the new INTERRUPTED reports have no error, as in Java. That will be fixed separately.