Repository navigation
test(web): catch preview bridge fixture drift during typecheck - #599
Merged
lastobelus merged 2 commits intoNov 5, 2026
Merged
Conversation
Remove the unreferenced Markdown source extension and two unused list helpers that fail the published checkpoint tree’s Knip gate. No runtime callers remain. Carry-Group: incubator Carry-Observation: Editor feature code remains with its feature integration.
Share an exhaustive preview bridge fixture in the two browser suites that missed setShown during checkpoint integration. Keep explicit behavior stubs and fail unexpected calls instead of casting partial bridges to complete ones. Carry-Group: incubator Carry-Observation: Keep preview fixtures and their feature-specific browser tests together.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
Checkpoint 4218 burned a full validation pass before two browser suites exposed missing
setShownstubs. Their partial preview-bridge mocks were cast to the complete type, so typechecking kept passing after the bridge contract changed.🔧 Changes
apps/web/test/previewBridge.ts(createPreviewBridgeFixture) lists every bridge member.ElectronBrowserHost.browser.test.tsxandHostedBrowserWebview.browser.test.tsxuse it instead of casting partial objects.apps/web/src/composer-markdown-source.ts(unreferenced Markdown source extension) and two unused list helpers inapps/web/src/composer-rich-text-doc.ts:splitOrLiftListItemandconvertBulletItemToTask. The same findings reproduced without the fixture changes.✅ Validation
setShownfrom the complete fixture fails with TS2322; restoring it passes. All three typechecks ran without cache reuse.check:changed origin/lastcode/main— passes format, lint, both Knip passes, two affected package typechecks, 341 tests, and the targeted React compiler check.This improves failure detection in the existing typecheck/preflight commands. It does not claim a measured whole-checkpoint speedup, and it does not avoid a validation run already in progress. Checkpoint validation, collection, worker limits, and publication guarantees are unchanged.
Model: GPT-6.1 Sol. Harness: Codex.