Skip to content

fix(preview): open same-machine managed previews directly and serialize viewport reads - #598

Merged
lastobelus merged 3 commits into
lastcode/mainfrom
t3/fix-managed-preview-local-streaming-click-zoom
Nov 5, 2026
Merged

lastobelus merged 3 commits into
lastcode/mainfrom
t3/fix-managed-preview-local-streaming-click-zoom

Conversation

@lastobelus

@lastobelus lastobelus commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Problem

  • Always streamed. Managed preview links always used the streaming route, even when the desktop could reach the app's listener on the same machine.
  • Viewport reads could overlap. Desktop-root viewport broadcasts could start overlapping native measurements.

Changes

  • Direct route on the same machine. When the environment confirms its local desktop browser connection, managed preview links open a direct desktop page instead of a stream.
  • Unchanged for everything else. Remote, unknown, and web/mobile clients keep the environment-hosted route. Recovery, retained tabs, and renewed navigation access are preserved. Healthy existing streams are not migrated.
  • Serialized viewport measurement. Desktop-root viewport broadcasts now go through the existing serialized native measurement path, so overlapping resize reads are coalesced.

What this does not establish

  • Wrong-button clicks are not fixed. The owner's report of wrong-button clicks at 80% zoom was not reproduced and is not conclusively fixed. The serialization change is a bounded ordering repair.
  • What the evidence shows. The mapping test and a real headless viewer both clicked correctly at 80%. The desktop-root regression test proves only serialization and coalescing, not click accuracy.
  • Still open. Reproducing the report in the desktop root; installed-desktop and cross-machine acceptance.
  • Stream quality is unchanged. Motion capture lowers resolution and JPEG quality. That needs its own visual investigation.

Validation

  • vp run check:changed origin/lastcode/main passed on the initial head: 336 tests, the React compiler check, format, lint, knip, graphql, and typecheck.
  • Quick CI passed on the initial head (677414b54c46303e3ceefd8ce9f11a66e3e8fa6c). For the explicit-runtime lookup repair at db5e15fcd8846db2589891c5c9760a27abf2cb49, local CI deferred to required GitHub checks because capacity was busy; 213 focused session-opening, routing, and handoff tests plus scoped format/lint passed.
  • Earlier targeted runs: 57 routing/handoff tests, 269 server tests, and 9 viewer browser tests passed.
  • Local review came back clean.

Model: GPT-6.1-Sol. Harness: Codex.

Keep remote and unknown hosts on the environment browser, preserve retained tabs and renewed navigation access.

Carry-Group: incubator
Use the existing native viewport reader for desktop roots to coalesce resize bursts. The exact reported wrong-button clicks remain unconfirmed.

Carry-Group: incubator
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T01:53:57.619013Z db5e15f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@lastobelus lastobelus changed the title fix(preview): open local managed apps directly and serialize viewport reads fix(preview): open same-machine managed previews directly and serialize viewport reads Nov 5, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 677414b54c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Preserve explicit runtime paths without consulting desktop host ownership.

Carry-Group: incubator
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: db5e15fcd8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lastobelus
lastobelus merged commit 57faf26 into lastcode/main Nov 5, 2026
20 checks passed
@lastobelus
lastobelus deleted the t3/fix-managed-preview-local-streaming-click-zoom branch November 5, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant