Repository navigation
Conversation
Also removed bounds_error=False, it is not needed when given fill_value="extrapolate".
Added acoustic wave verification See merge request hard/hard!3
1) Added comments so each step is easier to follow 2) Reduced the verbosity of some variables so the code is easier to read 3) Removed unnecessary variables
Fixed bug in Heun's method See merge request hard/hard!4
Update CI upstream See merge request hard/hard!9
Calculate fvm l2 error correctly See merge request hard/hard!10
Typed exactpack_verify.py, added a verify_lib to avoid repeating functions. Changed CMakeLists so that the convergence test exists. Removing scaling configurations Co-authored-by: Julien Loiseau <jloiseau@lanl.gov>
Convergence test See merge request hard/hard!6
Factored the Riemann solver, using it for radiation as well See merge request hard/hard!7
Lowering the acoustic amplitude for better convergence See merge request hard/hard!13
Use argparse See merge request hard/hard!71
This makes the spack package directory structure conform to the modern API
Fix spack package directory structure See merge request hard/hard!72
Fix some of the radiation configurations See merge request hard/hard!74
Add VTK, output option, and remove catalyst See merge request hard/hard!73
Make the lowest_level option not mandatory and update doc See merge request hard/hard!75
Fix distributed CSV comparison test
yrasool
changed the title
yrasool
changed the title
AndresYague
left a comment
AndresYague
left a comment
There was a problem hiding this comment.
Simple MR that makes the code more portable as it does not require that the system has cat. The code will be slower than running cat but not by a significant enough margin.
It may be useful to provide a buffer length of a few MB to shutil.copyfileobj to handle the 3D case output a bit faster.
Thanks, I added a 1 MiB buffer. In a local 128 MiB 3D-shaped merge, it was 1.34x faster than a 64 KiB buffer. The output test and docs check pass. |
This all looks good to me! |
Change
find_last_outputusedcatto merge rank CSV files. This now uses Python file I/O, with the existing output order unchanged.Checks
python tools/test_verify_output.pyruff check toolsgit diff --checkCMake and C++ unit tests were not run locally because CMake and FleCSI are not installed here.
Closes #15