fix: respect v4 appserver as default ssh service in mixed-api apps#461
Open
reynoldsalec wants to merge 1 commit intomainfrom
Open
fix: respect v4 appserver as default ssh service in mixed-api apps#461reynoldsalec wants to merge 1 commit intomainfrom
reynoldsalec wants to merge 1 commit intomainfrom
Conversation
When an app has both v3 and v4 services, the default service for `lando ssh` would incorrectly fall back to the first v3 service even if a v4 `appserver` existed. Now the fallback checks all API groups before overriding the default.
✅ Deploy Preview for lando-core ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an app has both v3 and v4 services, the default service for
lando sshwould incorrectly fall back to the first v3 service even if a v4appserverexisted. Now the fallback checks all API groups before overriding the default.The logic of defaulting to a v3 service if there is no appserver is a little weird...open to suggestion there.