Themes generated from palettes - #9
Merged
Merged
Conversation
A dark palette applied without html.dark got a bar at the text lightness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eight themes were two kinds of file.
dracula,nordandone-darkdeclared 46 concrete tokens; the five ported ones declared nine seeds and let the rest derive. Measured in oklab, 17 to 20 of the 25 comparable tokens differed per theme, and in one direction: the hand-written borders are far more subdued than the derived ones.Every theme is now generated from a palette of fourteen colours. The recipe is not invented: it was read back out of the three hand-written themes, which turned out to be 46 tokens built from 11 to 13 colours reused by role.
The generator reproduces
dracula,nordandone-darktoken for token, 46 each, zero differences. Where a palette wants something off the recipe it says so underoverrides: three entries indracula, five inone-dark, none innord.pnpm test:themesnow asserts that every theme declares the same token set, that each palette carries all fourteen levels, and that the committed CSS still matches its palette. Removing a level reportsmissing overlay, not a stack trace.