Readable theme manifest - #8
Merged
Merged
Conversation
Kasui92
force-pushed
the
fix/theme-manifest-js
branch
from
September 6, 2026 21:53
192f0a9 to
c5653e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theme manifest shipped as TypeScript, and Node refuses to strip types from files under
node_modules— so@lancher-dev/jaamd/themeswas readable by bundlers and by nothing else. Any consumer building tooling on the manifest, a test runner included, gotERR_UNSUPPORTED_NODE_MODULES_TYPE_STRIPPING.It is plain JavaScript now, with the types beside it in
index.d.ts. Verified against a packed tarball installed into an empty project, not the workspace symlink, which resolves outsidenode_modulesand hid the problem:Every published specifier still resolves from that same install,
@lancher-dev/jaamd/themesincluded.