feat!: show index segment count and size - #774
Open
ddupg wants to merge 1 commit into
Open
Conversation
ddupg
marked this pull request as ready for review
August 20, 2026 13:13
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-approved
ddupg
force-pushed
the
feat/ddu-356-show-index-segment-stats
branch
from
August 24, 2026 06:08
737e330 to
1c75fad
Compare
ddupg
changed the title
github-actions
Bot
added
the
breaking-change
lance-gatekeeper
Bot
removed
the
K-approved
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The implementation preserves one logical row per index, reports the physical-segment count, and returns NULL instead of a partial total when any segment lacks size metadata. It remains a thin aggregation over the existing Lance metadata path, with documentation and real multi-segment coverage matching the new schema.
lance-gatekeeper
Bot
added
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
segment_countandtotal_size_bytestoSHOW INDEXES.NULLfor total size when any segment size is missing.Tests
./mvnw test -pl lance-spark-3.5_2.12 -am -Dtest=ShowIndexesExecTest,ShowIndexesTest -Dsurefire.failIfNoSpecifiedTests=false./mvnw test -pl lance-spark-3.5_2.13 -am -Dtest=ShowIndexesExecTest,ShowIndexesTest -Dsurefire.failIfNoSpecifiedTests=false./mvnw spotless:check