Repository navigation
fix: use deregisterTable for dropTable and dropTable for purgeTable - #209
Merged
jackye1995 merged 2 commits intoFeb 6, 2026
Merged
Conversation
jackye1995
force-pushed
the
fix-drop-table-semantics
branch
from
February 6, 2026 00:43
9eb8261 to
4de2127
Compare
jackye1995
changed the title
- dropTable now calls namespace.deregisterTable() which only removes metadata without deleting the underlying data - purgeTable now calls namespace.dropTable() which removes metadata and deletes the underlying data - Updated DirectoryNamespace tests to disable extra_level config and explicitly create the "default" namespace so that manifest mode is used instead of directory listing mode 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
force-pushed
the
fix-drop-table-semantics
branch
from
February 6, 2026 00:56
4de2127 to
9225261
Compare
jackye1995
changed the title
ivscheianu
pushed a commit
to ivscheianu/lance-spark
that referenced
this pull request
Jul 20, 2026
…ance-format#209) ## Summary - `dropTable()` now calls `namespace.deregisterTable()` which only removes metadata without deleting the underlying data - `purgeTable()` now calls `namespace.dropTable()` which removes metadata and deletes the underlying data ## Changes - Modified `dropTable()` to use `DeregisterTableRequest` and call `namespace.deregisterTable()` - Modified `purgeTable()` to use `DropTableRequest` and call `namespace.dropTable()` - Updated DirectoryNamespace tests to disable `extra_level` config and explicitly create the "default" namespace so that manifest mode is used instead of directory listing mode ## Related PR - lance-format/lance-namespace-impls#12 (implements `dropTable` and `deregisterTable` with proper `deleteData` handling in hive2/hive3 namespaces) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dropTable()now callsnamespace.deregisterTable()which only removes metadata without deleting the underlying datapurgeTable()now callsnamespace.dropTable()which removes metadata and deletes the underlying dataChanges
dropTable()to useDeregisterTableRequestand callnamespace.deregisterTable()purgeTable()to useDropTableRequestand callnamespace.dropTable()extra_levelconfig and explicitly create the "default" namespace so that manifest mode is used instead of directory listing modeRelated PR
dropTableandderegisterTablewith properdeleteDatahandling in hive2/hive3 namespaces)🤖 Generated with Claude Code