Skip to content

chore: bump lance namespace core to 0.13.0 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hfutatzhanghb wants to merge 1 commit into from
Closed

chore: bump lance namespace core to 0.13.0 #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion java/lance-namespace-glue/src/main/java/org/lance/namespace/glue/GlueNamespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.lance.namespace.model.ListTablesRequest;
import org.lance.namespace.model.ListTablesResponse;
import org.lance.namespace.model.TableExistsRequest;
import org.lance.namespace.model.TableExistsResponse;
import org.lance.namespace.util.LanceTableUtil;

import com.google.common.annotations.VisibleForTesting;
Expand Down Expand Up @@ -269,13 +270,14 @@ public DescribeTableResponse describeTable(DescribeTableRequest request) {
}

@Override
public void tableExists(TableExistsRequest request) {
public TableExistsResponse tableExists(TableExistsRequest request) {
validateTableId(request.getId());
String namespaceName = request.getId().get(0);
String tableName = request.getId().get(1);

Table table = getGlueTable(namespaceName, tableName);
ensureLanceTable(table);
return new TableExistsResponse();
}

@Override
Expand Down
9 changes: 7 additions & 2 deletions java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@
import org.lance.namespace.model.ListTablesRequest;
import org.lance.namespace.model.ListTablesResponse;
import org.lance.namespace.model.NamespaceExistsRequest;
import org.lance.namespace.model.NamespaceExistsResponse;
import org.lance.namespace.model.TableExistsRequest;
import org.lance.namespace.model.TableExistsResponse;
import org.lance.namespace.util.LanceTableUtil;

import com.google.common.collect.Lists;
Expand Down Expand Up @@ -147,7 +149,7 @@ public CreateNamespaceResponse createNamespace(CreateNamespaceRequest request) {
}

@Override
public void namespaceExists(NamespaceExistsRequest request) {
public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) {
ObjectIdentifier id = ObjectIdentifier.of(request.getId());

ValidationUtil.checkArgument(
Expand All @@ -162,6 +164,8 @@ public void namespaceExists(NamespaceExistsRequest request) {
HiveMetaStoreError.getType(),
id.stringStyleId());
}

return new NamespaceExistsResponse();
}

@Override
Expand Down Expand Up @@ -247,7 +251,7 @@ public ListTablesResponse listTables(ListTablesRequest request) {
}

@Override
public void tableExists(TableExistsRequest request) {
public TableExistsResponse tableExists(TableExistsRequest request) {
ObjectIdentifier tableId = ObjectIdentifier.of(request.getId());

ValidationUtil.checkArgument(
Expand All @@ -266,6 +270,7 @@ public void tableExists(TableExistsRequest request) {
}

Hive2Util.validateLanceTable(hmsTable.get());
return new TableExistsResponse();
}

@Override
Expand Down
9 changes: 7 additions & 2 deletions java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@
import org.lance.namespace.model.ListTablesRequest;
import org.lance.namespace.model.ListTablesResponse;
import org.lance.namespace.model.NamespaceExistsRequest;
import org.lance.namespace.model.NamespaceExistsResponse;
import org.lance.namespace.model.TableExistsRequest;
import org.lance.namespace.model.TableExistsResponse;
import org.lance.namespace.util.LanceTableUtil;

import com.google.common.collect.Lists;
Expand Down Expand Up @@ -196,7 +198,7 @@ public DescribeNamespaceResponse describeNamespace(DescribeNamespaceRequest requ
}

@Override
public void namespaceExists(NamespaceExistsRequest request) {
public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) {
ObjectIdentifier id = ObjectIdentifier.of(request.getId());

ValidationUtil.checkArgument(
Expand All @@ -220,6 +222,8 @@ public void namespaceExists(NamespaceExistsRequest request) {
String.format("Namespace does not exist: %s", id.stringStyleId()));
}
}

return new NamespaceExistsResponse();
}

@Override
Expand All @@ -243,7 +247,7 @@ public DropNamespaceResponse dropNamespace(DropNamespaceRequest request) {
}

@Override
public void tableExists(TableExistsRequest request) {
public TableExistsResponse tableExists(TableExistsRequest request) {
ObjectIdentifier tableId = ObjectIdentifier.of(request.getId());

ValidationUtil.checkArgument(
Expand All @@ -261,6 +265,7 @@ public void tableExists(TableExistsRequest request) {
}

Hive3Util.validateLanceTable(hmsTable.get());
return new TableExistsResponse();
}

@Override
Expand Down
8 changes: 6 additions & 2 deletions java/lance-namespace-iceberg/src/main/java/org/lance/namespace/iceberg/IcebergNamespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
import org.lance.namespace.model.ListTablesRequest;
import org.lance.namespace.model.ListTablesResponse;
import org.lance.namespace.model.NamespaceExistsRequest;
import org.lance.namespace.model.NamespaceExistsResponse;
import org.lance.namespace.model.TableExistsRequest;
import org.lance.namespace.model.TableExistsResponse;
import org.lance.namespace.rest.RestClient;
import org.lance.namespace.rest.RestClientException;
import org.lance.namespace.util.LanceTableUtil;
Expand Down Expand Up @@ -265,8 +267,9 @@ public DescribeNamespaceResponse describeNamespace(DescribeNamespaceRequest requ
}

@Override
public void namespaceExists(NamespaceExistsRequest request) {
public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) {
describeNamespace(new DescribeNamespaceRequest().id(request.getId()));
return new NamespaceExistsResponse();
}

@Override
Expand Down Expand Up @@ -457,8 +460,9 @@ public DescribeTableResponse describeTable(DescribeTableRequest request) {
}

@Override
public void tableExists(TableExistsRequest request) {
public TableExistsResponse tableExists(TableExistsRequest request) {
describeTable(new DescribeTableRequest().id(request.getId()));
return new TableExistsResponse();
}

@Override
Expand Down
8 changes: 6 additions & 2 deletions java/lance-namespace-polaris/src/main/java/org/lance/namespace/polaris/PolarisNamespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
import org.lance.namespace.model.ListTablesRequest;
import org.lance.namespace.model.ListTablesResponse;
import org.lance.namespace.model.NamespaceExistsRequest;
import org.lance.namespace.model.NamespaceExistsResponse;
import org.lance.namespace.model.TableExistsRequest;
import org.lance.namespace.model.TableExistsResponse;
import org.lance.namespace.rest.RestClient;
import org.lance.namespace.rest.RestClientException;
import org.lance.namespace.util.LanceTableUtil;
Expand Down Expand Up @@ -223,7 +225,7 @@ public DropNamespaceResponse dropNamespace(DropNamespaceRequest request) {
}

@Override
public void namespaceExists(NamespaceExistsRequest request) {
public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) {
ObjectIdentifier namespaceId = ObjectIdentifier.of(request.getId());
ValidationUtil.checkArgument(
namespaceId.levels() >= 2, "Namespace must have at least catalog and namespace levels");
Expand All @@ -236,6 +238,7 @@ public void namespaceExists(NamespaceExistsRequest request) {

restClient.get(
"/v1/" + catalog + "/namespaces/" + namespacePath, PolarisModels.NamespaceResponse.class);
return new NamespaceExistsResponse();
} catch (RestClientException e) {
if (e.isNotFound()) {
throw new NamespaceNotFoundException("Namespace not found: " + namespaceId.stringStyleId());
Expand All @@ -245,7 +248,7 @@ public void namespaceExists(NamespaceExistsRequest request) {
}

@Override
public void tableExists(TableExistsRequest request) {
public TableExistsResponse tableExists(TableExistsRequest request) {
ObjectIdentifier tableId = ObjectIdentifier.of(request.getId());
ValidationUtil.checkArgument(
tableId.levels() >= 3, "Table identifier must have catalog, namespace, and table name");
Expand All @@ -265,6 +268,7 @@ public void tableExists(TableExistsRequest request) {
+ "/generic-tables/"
+ tableName,
PolarisModels.LoadGenericTableResponse.class);
return new TableExistsResponse();
} catch (RestClientException e) {
if (e.isNotFound()) {
throw new TableNotFoundException("Table not found: " + tableId.stringStyleId());
Expand Down
8 changes: 6 additions & 2 deletions java/lance-namespace-unity/src/main/java/org/lance/namespace/unity/UnityNamespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
import org.lance.namespace.model.ListTablesRequest;
import org.lance.namespace.model.ListTablesResponse;
import org.lance.namespace.model.NamespaceExistsRequest;
import org.lance.namespace.model.NamespaceExistsResponse;
import org.lance.namespace.model.TableExistsRequest;
import org.lance.namespace.model.TableExistsResponse;
import org.lance.namespace.rest.RestClient;
import org.lance.namespace.rest.RestClientException;
import org.lance.namespace.util.LanceTableUtil;
Expand Down Expand Up @@ -223,8 +225,9 @@ public DescribeNamespaceResponse describeNamespace(DescribeNamespaceRequest requ
}

@Override
public void namespaceExists(NamespaceExistsRequest request) {
public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) {
describeNamespace(new DescribeNamespaceRequest().id(request.getId()));
return new NamespaceExistsResponse();
}

@Override
Expand Down Expand Up @@ -419,8 +422,9 @@ public DescribeTableResponse describeTable(DescribeTableRequest request) {
}

@Override
public void tableExists(TableExistsRequest request) {
public TableExistsResponse tableExists(TableExistsRequest request) {
describeTable(new DescribeTableRequest().id(request.getId()));
return new TableExistsResponse();
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<lance-core.version>7.0.0</lance-core.version>
<lance-namespace.version>0.7.7</lance-namespace.version>
<lance-namespace.version>0.13.0</lance-namespace.version>
<arrow.version>18.3.0</arrow.version>
<netty.version>4.1.118.Final</netty.version>
<junit-version>5.8.2</junit-version>
Expand Down
Loading