Repository navigation
Conversation
hfutatzhanghb
force-pushed
the
agent/centralize-java-dependency-versions
branch
from
July 13, 2026 06:14
26410cd to
729246b
Compare
hfutatzhanghb
changed the title
hfutatzhanghb
force-pushed
the
agent/centralize-java-dependency-versions
branch
from
July 13, 2026 06:29
d11881e to
571c07d
Compare
hfutatzhanghb
force-pushed
the
agent/centralize-java-dependency-versions
branch
2 times, most recently
from
October 8, 2026 03:53
14f0f8a to
1a1ea3f
Compare
Centralize shared Java dependency and plugin versions in the root Maven properties, keep module-specific overrides, and align the Hadoop property name. Emit Unity Catalog column type_json values as complete StructField JSON in both Java and Python, with unit coverage for each table declaration payload.
hfutatzhanghb
force-pushed
the
agent/centralize-java-dependency-versions
branch
from
October 8, 2026 06:05
1a1ea3f to
4b06ffc
Compare
Contributor
Author
|
Hi, @geruh . Could you please help review this PR when have free time? Thanks very much! |
geruh
reviewed
Oct 10, 2026
| unity_type = self._convert_arrow_type_to_unity_type(arrow_field.type) | ||
| unity_type_json = self._convert_arrow_type_to_unity_type_json( | ||
| arrow_field.type | ||
| unity_type_json = self._create_unity_type_json( |
Collaborator
There was a problem hiding this comment.
we are including a fix for unity payloads too? This is fine by me just calling it out
Contributor
Author
There was a problem hiding this comment.
@geruh Yes, this needs to be included in this PR — otherwise the CI build will fail. Thanks for flagging it!
geruh
reviewed
Oct 10, 2026
geruh
left a comment
geruh
left a comment
Collaborator
There was a problem hiding this comment.
LGTM thanks for the cleanup @hfutatzhanghb!
geruh
approved these changes
Oct 10, 2026
Contributor
Author
|
@geruh Sir, Thanks very much for your reivewing and merging!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type_jsonvalues as complete StructField JSON withname,type,nullable, andmetadatain both Java and PythonValidation
git diff --check origin/main...HEADxmllint --noout java/pom.xml java/lance-namespace-hive2/pom.xml java/lance-namespace-hive3/pom.xml java/lance-namespace-iceberg/pom.xml java/lance-namespace-unity/pom.xml java/lance-namespace-glue/pom.xmlruff checkpassed for the Python Unity implementation and testsruff format --checkpassed for the Python Unity implementation and testspython3 -m py_compile python/src/lance_namespace_impls/unity.py python/tests/test_unity.pyLocal Unity integration tests were not run because the Docker CLI is not executable in this environment. GitHub Actions is the integration validation gate for the updated commit.