Skip to content

chore: remove permissive CORS from server and master #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beinan merged 1 commit into from
Jul 25, 2026
Merged

chore: remove permissive CORS from server and master #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/lance-context-master/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ reqwest = { version = "0.12", default-features = false, features = ["json", "rus
serde = { version = "1", features = ["derive"] }
serde_json = "1"
tokio = { version = "1", features = ["rt-multi-thread", "macros", "signal", "sync"] }
tower-http = { version = "0.6", features = ["cors", "fs", "trace"] }
tower-http = { version = "0.6", features = ["fs", "trace"] }
tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["env-filter"] }

Expand Down
4 changes: 1 addition & 3 deletions crates/lance-context-master/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use axum::Router;
use clap::Parser;
use tokio::net::TcpListener;
use tower_http::cors::CorsLayer;
use tower_http::services::ServeDir;
use tower_http::trace::TraceLayer;
use tracing_subscriber::EnvFilter;
Expand Down Expand Up @@ -66,8 +65,7 @@ async fn main() {
.layer(axum::middleware::from_fn(
lance_context_metrics::http_metrics_layer,
))
.layer(TraceLayer::new_for_http())
.layer(CorsLayer::permissive());
.layer(TraceLayer::new_for_http());

tracing::info!("Starting lance-context-master on {}", addr);

Expand Down
2 changes: 1 addition & 1 deletion crates/lance-context-server/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ lru = "0.12"
serde = { version = "1", features = ["derive"] }
serde_json = "1"
tokio = { version = "1", features = ["rt-multi-thread", "macros", "signal"] }
tower-http = { version = "0.6", features = ["cors", "trace"] }
tower-http = { version = "0.6", features = ["trace"] }
tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["env-filter"] }
uuid = { version = "1", features = ["v4"] }
Expand Down
4 changes: 1 addition & 3 deletions crates/lance-context-server/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use std::sync::Arc;

use clap::Parser;
use tokio::net::TcpListener;
use tower_http::cors::CorsLayer;
use tower_http::trace::TraceLayer;
use tracing_subscriber::EnvFilter;

Expand Down Expand Up @@ -74,8 +73,7 @@ async fn main() {
.layer(axum::middleware::from_fn(
lance_context_metrics::http_metrics_layer,
))
.layer(TraceLayer::new_for_http())
.layer(CorsLayer::permissive());
.layer(TraceLayer::new_for_http());

tracing::info!("Starting lance-context-server on {}", addr);

Expand Down
Loading