Skip to content

docs: drop implemented RPC endpoints from the near-future roadmap#439

Merged
MegaRedHand merged 1 commit into
mainfrom
update_readme
Jun 16, 2026
Merged

docs: drop implemented RPC endpoints from the near-future roadmap#439
MegaRedHand merged 1 commit into
mainfrom
update_readme

Conversation

@pablodeymo

Copy link
Copy Markdown
Collaborator

🗒️ Description / Motivation

The roadmap's "near future" section still listed RPC endpoints for chain data consumption (#75) as upcoming work. The RPC API server already exposes chain-data endpoints (finalized state, blocks, headers, justified checkpoint, fork choice), so this item no longer belongs in the upcoming-features list.

What Changed

Correctness / Behavior Guarantees

  • Documentation only; no behavior change.

Tests Added / Run

  • None (docs-only change).

Related Issues / PRs

…roadmap

  The RPC API server now exposes chain-data endpoints (states, blocks,
  checkpoints, fork choice), so this item no longer belongs in the list
  of upcoming features.
@github-actions

Copy link
Copy Markdown

🤖 Kimi Code Review

This is a documentation-only change removing a completed or deprioritized roadmap item. The diff is clean and presents no technical issues.

Specific observations:

README.md (lines 139-140)

  • Markdown list formatting remains valid after removing the first bullet point
  • The remaining ZK proving item maintains proper list structure

Suggestions:

  1. If RPC endpoints were completed, consider adding them to a "Implemented Features" section in the README rather than just deleting the reference, or ensure they're documented in the crate-level documentation.
  2. If this represents deprioritization, no further action needed beyond the removal.

No security, correctness, or performance concerns identified in this documentation update.


Automated review by Kimi (Moonshot AI) · kimi-k2.5 · custom prompt

@github-actions

Copy link
Copy Markdown

🤖 Codex Code Review

No findings.

The diff only removes a roadmap bullet from README.md. It does not touch consensus logic, networking, SSZ, signature handling, or any executable Rust code, so I do not see correctness, security, performance, or maintainability risks in this PR.

Residual risk is effectively none beyond documentation accuracy.


Automated review by OpenAI Codex · gpt-5.4 · custom prompt

@github-actions

Copy link
Copy Markdown

🤖 Claude Code Review

The diff is a single-line documentation removal. Here's the review:


PR Review: docs: drop implemented RPC endpoints from the near-future roadmap

Overview

This is a docs-only change — one line removed from README.md. The near-future roadmap item linking to issue #75 ("RPC endpoints for chain data consumption") is removed because those endpoints have already been shipped.

Correctness

The removal is accurate. The following endpoints are already live on the API server (:5052):

  • GET /lean/v0/states/finalized
  • GET /lean/v0/checkpoints/justified
  • GET /lean/v0/fork_choice
  • GET /lean/v0/blocks/{block_id}
  • GET /lean/v0/blocks/{block_id}/header

Keeping a "near future" entry for something already implemented would mislead contributors about what's left to build, so this removal is the right call.

Minor Observations

  • The PR closes issue Add JSON-RPC endpoints for blocks #75 via the description (Closes #75), which is correct — the issue should be closed now that the feature is implemented.
  • No behavioral change, no tests needed.

Verdict

Approve. The change is minimal, accurate, and properly motivated. Nothing to flag.


Automated review by Claude (Anthropic) · sonnet · custom prompt

@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This is a documentation-only change that removes a completed roadmap item from the README.md. The "near-future" section previously listed RPC endpoints for chain data consumption as upcoming work, but that functionality has since been implemented.

  • Removes the [RPC endpoints for chain data consumption](https://github.com/lambdaclass/ethlambda/issues/75) line item from the near-future roadmap in README.md.
  • No code behavior is altered; this purely keeps the roadmap in sync with what has already shipped.

Confidence Score: 5/5

Safe to merge — documentation-only removal of a completed roadmap entry.

The change removes a single line from the README roadmap to reflect work that has already shipped. There is no code, configuration, or schema involved, and the remaining roadmap content is untouched.

No files require special attention.

Important Files Changed

Filename Overview
README.md Removes one completed roadmap bullet (RPC endpoints, issue #75) from the near-future features list — straightforward docs cleanup with no risk.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[README.md Near-Future Roadmap] --> B{Issue #75 implemented?}
    B -- Yes --> C[Remove RPC endpoints line item]
    B -- No --> D[Keep in roadmap]
    C --> E[Remaining: Add guest program & ZK proving - issue #156]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[README.md Near-Future Roadmap] --> B{Issue #75 implemented?}
    B -- Yes --> C[Remove RPC endpoints line item]
    B -- No --> D[Keep in roadmap]
    C --> E[Remaining: Add guest program & ZK proving - issue #156]
Loading

Reviews (1): Last reviewed commit: "Remove RPC endpoints for chain data cons..." | Re-trigger Greptile

@MegaRedHand MegaRedHand merged commit d334797 into main Jun 16, 2026
7 checks passed
@MegaRedHand MegaRedHand deleted the update_readme branch June 16, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add JSON-RPC endpoints for blocks

2 participants