Repository navigation
fix(env): give the login shell probe 10 s, not 3 - #920
Merged
Merged
Conversation
A login zsh took 3.02 s on graphite, so the probe timed out on every launch and fell back to the static PATH list, which misses nvm/fnm installs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A live test of #917 on graphite (2019 Intel MacBook Pro) logged
login shell probe timed out after 3sandUser PATH resolved from Fallbackon every launch. Timingzsh -ilcthere: 3.02 s real.The fallback still found
npxthere (Homebrew in /usr/local/bin), but anyone whose node comes from nvm, fnm or a shell-managed version would get a PATH without it, so MCP servers run through npx would not start.The probe runs off the main thread and its result is cached for the process, so 10 s costs nothing on fast shells and only delays the first MCP server start on a slow one.
QA: launch Juno from the Dock on a machine with a slow shell; the log should say
User PATH resolved from LoginShell.