Repository navigation
fix: keep detector findings and writer byte accounting correct under stalls - #316
Merged
Merged
Conversation
…stalls An audit of detector and writer behaviour under saturation reproduced these defects, and a review found one more: - Log patterns filtered and took extrema on the original OTLP timestamp, so logs with only an observed time disappeared. They now use canonical native event time. - A stalled service watermark froze log patterns. Anomaly evaluation is memoised per completed minute; patterns run on their own cadence and the snapshot is rebuilt. - A failed pattern query was published as a healthy snapshot and never retried. The error now propagates and the query is retried. - A pending annotation batch replaced before persistence lost a short incident. Displaced findings now merge into the replacement with their evaluated intervals. - Anomaly findings evaluated before a failed pattern query were dropped once the watermark advanced. They now carry over, bounded, to the next successful publication. - The writer released a request's byte reservation when its caller gave up while the request was still queued or committing, bypassing the decoded-byte budget. The reservation now moves with the request and is released exactly once when its payload is no longer held. Claude-Session: https://claude.ai/code/session_01XA52nWyQ3R5f5kK8kjpAQW
vishr
force-pushed
the
fix/detector-and-accounting
branch
from
October 15, 2026 20:36
8258b87 to
11a88b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An audit of detector and writer behaviour under saturation reproduced five defects. An adversarial review of the fixes found a sixth. Each one now has a regression test.
Durable acknowledgement, configuration and formats are unchanged.
Test plan
just checkjust test-racehttps://claude.ai/code/session_01XA52nWyQ3R5f5kK8kjpAQW