Skip to content

Change password - #7368

Open
shortlight5980 wants to merge 2 commits into
labring:mainfrom
shortlight5980:change-password
Open

Change password#7368
shortlight5980 wants to merge 2 commits into
labring:mainfrom
shortlight5980:change-password

Conversation

@shortlight5980

@shortlight5980 shortlight5980 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

基于unsubscribe账号注销分支,可以等账号注销合并后再review或合并


  1. 修改密码根据用户种类进行身份认证
  2. 主要改动是取消了密码的必填性

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 34.3% 3474 / 10128
🔵 Statements 34.22% 3672 / 10729
🔵 Functions 28.97% 698 / 2409
🔵 Branches 29.15% 1773 / 6082
File CoverageNo changed files found.
Generated in workflow #3111 for commit c4b2213 by the Vitest Coverage Report Action

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

Docs preview deployed

🔗 👀 Click here to visit preview

ghcr.io/labring/fastgpt-docs-pr:c4b2213f4aab87035d68bb8ad7dcd8dd1b32f81e

🕒 Time: 2026-09-08 16:49:36 (UTC+8)

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

Admin Preview Image Ready!

ghcr.io/labring/fastgpt-pr:admin_c4b2213f4aab87035d68bb8ad7dcd8dd1b32f81e

🕒 Time: 2026-09-08 16:52:30 (UTC+8)

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

Build and publish successful - Preview fastgpt Image:

ghcr.io/labring/fastgpt-pr:fastgpt_c4b2213f4aab87035d68bb8ad7dcd8dd1b32f81e

🕒 Time: 2026-09-08 16:53:04 (UTC+8)

@c121914yu
c121914yu requested a review from FinleyGe July 26, 2026 09:19
@FinleyGe FinleyGe self-assigned this Jul 27, 2026
@shortlight5980
shortlight5980 force-pushed the change-password branch 7 times, most recently from f364133 to 8dedd68 Compare August 13, 2026 08:24
@cla-assistant

cla-assistant Bot commented Aug 13, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@shortlight5980
shortlight5980 force-pushed the change-password branch 4 times, most recently from f3627ab to d419bc3 Compare August 16, 2026 05:32
@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

✅ Docs preview image built successfully for c85ecfa38cc8f370635a0409ca806081f70f9eef.

Automatic publishing is disabled for this PR. A maintainer can comment:

/preview push

to publish the image from this exact build.

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

✅ Preview images built successfully for c85ecfa38cc8f370635a0409ca806081f70f9eef.

Automatic publishing is disabled for this PR. A maintainer can comment:

/preview push

to publish the images from this exact build.

@shortlight5980
shortlight5980 force-pushed the change-password branch 6 times, most recently from 85e2c0f to 3ab3981 Compare August 31, 2026 03:14
Comment thread packages/global/openapi/support/user/account/password/index.ts
@shortlight5980
shortlight5980 force-pushed the change-password branch 8 times, most recently from 1f5ce55 to 9fe6742 Compare September 2, 2026 08:27
Comment thread document/content/self-host/config/env.en.mdx Outdated
@FinleyGe

FinleyGe commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

P2: Add direct success coverage for Pro verification-material creation. pro/admin/src/service/support/user/account/password/verification/service.ts:142-176 has separate success branches for code, old-password, WeChat QR, and OAuth authorization URL creation, but pro/admin/test/service/support/user/account/password/verification/service.test.ts only covers method resolution and consumption; pro/admin/test/api/support/user/account/password/authorization.test.ts only exercises old-password creation. Please add focused tests for the code-send payload, WeChat QR response, and OAuth URL/state output so regressions in these user-facing entry points are caught.

@shortlight5980

Copy link
Copy Markdown
Collaborator Author

P2: Add direct success coverage for Pro verification-material creation. pro/admin/src/service/support/user/account/password/verification/service.ts:142-176 has separate success branches for code, old-password, WeChat QR, and OAuth authorization URL creation, but pro/admin/test/service/support/user/account/password/verification/service.test.ts only covers method resolution and consumption; pro/admin/test/api/support/user/account/password/authorization.test.ts only exercises old-password creation. Please add focused tests for the code-send payload, WeChat QR response, and OAuth URL/state output so regressions in these user-facing entry points are caught.

resolved

Comment thread packages/global/support/user/type.ts
Comment thread pnpm-workspace.yaml Outdated
@shortlight5980
shortlight5980 force-pushed the change-password branch 4 times, most recently from f645324 to 75c469b Compare September 7, 2026 08:04
@shortlight5980
shortlight5980 force-pushed the change-password branch 2 times, most recently from 5044c36 to cd995f1 Compare September 8, 2026 08:43
Comment on lines +638 to +642
{t(
createFailed
? 'common:password_wechat_load_failed'
: 'common:password_wechat_expired'
)}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] i18n key 不能放在条件表达式里

这里的 t(createFailed ? 'common:password_wechat_load_failed' : 'common:password_wechat_expired') 不符合项目要求:翻译 key 必须在最终调用处保持 t('ns:literal_key'),否则语言包清理脚本可能无法识别引用,误删 key,导致二维码加载失败/过期时裸显 key。当前三种语言里已有翻译也不能消除后续清理风险。请把条件判断移到 t 调用外:

Suggested change
{t(
createFailed
? 'common:password_wechat_load_failed'
: 'common:password_wechat_expired'
)}
{createFailed
? t('common:password_wechat_load_failed')
: t('common:password_wechat_expired')}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants