Repository navigation
fix(server): secure video temp files and snapshot allowlists - #2282
Merged
Merged
Conversation
Materialize client video bytes inside a private directory whose guard exists before the blocking write begins, so cancellation and partial-write failures cannot leave readable files behind. Resolve the local-video allowlist once at startup across HTTP, router-model, and in-process server paths, and document the restart requirement. Refs #1787
State that the end-to-end model check ran on Linux CUDA and that macOS Metal inference was not run locally, without implying active CI coverage. Refs #1787
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
data:video/mp4request answered that the clip was red with 83 prompt and 9 completion tokens; the private temp root was empty before and after.cargo fmt --all -- --checkandgit diff --checkpassed.CUDA end-to-end coverage was run locally. macOS Metal inference was not run locally.
Fixes #1787