Repository navigation
fix(scripts): create portable A/B output directories - #2276
Merged
Merged
Conversation
Use mktemp templates accepted by GNU and BSD implementations, then stop with the documented inconclusive status when no output directory exists. Add stub-backed regression coverage for both A/B gates' default and failure paths. Refs #2141
Exercise both gates when TMPDIR cannot host a temporary directory and assert that each returns status 2 before invoking a model binary. Allow the test to target a detached baseline tree so the regression remains demonstrable. Refs #2141
inureyes
added
type:bug
Make the fake curl consume the piped request body so pipefail cannot report a producer SIGPIPE as a paged-gate failure. Print captured gate output whenever a default-path assertion fails. Refs #2141
Record the portable output-directory fix, the fixture stability decision, and focused validation results in English and Korean. Refs #2141
inureyes
added a commit
that referenced
this pull request
Oct 12, 2026
Merge origin/main at 2cb4e20 after the portable A/B output directory fix landed. This incorporates the #2209 and #2276 prerequisite changes while leaving the split-MTP implementation and regression-test paths unchanged. Validation: - configured repository contracts - cargo deny check - cargo fmt --all -- --check - staged and unstaged whitespace checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mktemptemplates.Validation
bash scripts/ci/ab_scripts_outdir_test.shbash -n scripts/ab_output_equality.sh scripts/paged_decode_counter_ab.sh scripts/ci/ab_scripts_outdir_test.shgit diff --checkCloses #2141