Repository navigation
feat(ssh): add CTAP 2.1 UV token signing - #346
Merged
Merged
Conversation
Built-in-sensor authenticators that advertise `pinUvAuthToken` now obtain a permission-scoped token through clientPIN subcommand 0x06, authenticate GetAssertion without sending the `uv` option, and fall back to the existing PIN prompt and subcommand 0x09 path when the sensor refuses verification. CTAP 2.0 devices retain their direct `options.uv` flow. Extend the mock transport and focused tests across PIN/UV protocols 1 and 2, update the compatibility ledger, and track deferred WebAuthn host-signature support in #345. Validated with formatting, clippy on library and tests, the 99-test security-key slice, the 3-test binary query slice, and the 12-test transport-algorithm slice. Refs #339
inureyes
added
type:enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x06for built-in-sensor authenticators, then authenticate GetAssertion while omittingoptions.uv.PinRequiredwhen sensor verification is refused so a PIN retry uses the existing0x09path; cover both PIN/UV auth protocols 1 and 2.options.uvpath and update the compatibility ledger.ssh-keyandrusshstack cannot verify those signatures yet.Test plan
cargo fmt --checkCARGO_BUILD_JOBS=5 cargo clippy --lib --tests -- -D warningsCARGO_BUILD_JOBS=5 cargo test --lib security_key -- --test-threads=1(99 passed)CARGO_BUILD_JOBS=5 cargo test --bin bssh app::query -- --test-threads=1(3 passed)CARGO_BUILD_JOBS=5 cargo test --lib ssh::tokio_client::algorithms::tests -- --test-threads=1(12 passed)Closes #339