Repository navigation
build: bump Launchpad PPA toolchain and MSRV to Rust 1.97 - #341
Merged
Merged
Conversation
The lablup rustc-release dependency PPA now publishes rustc-1.97 and cargo-1.97 for jammy, noble, and resolute, so move the declared MSRV and the Debian/Launchpad toolchain from 1.96 to 1.97, following #231. The CI msrv job reads rust-version and now checks on 1.97. The Cargo.toml note now says resolute also builds with the rustc-release PPA toolchain; the resolute archive only carries Rust 1.93. Validation: cargo +1.97.1 check --workspace --locked passes, and an offline dpkg-buildpackage -b using the PPA's cargo-1.97 with vendored, sanitized dependencies succeeds in clean jammy, noble, and resolute containers.
inureyes
added
status:review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the Debian/Launchpad packaging toolchain and the declared MSRV from Rust 1.96 to 1.97 now that the lablup
rustc-releasedependency PPA (~lablup/+archive/ubuntu/rustc-release) publishesrustc-1.97andcargo-1.97(1.97.1+dfsg1-0ubuntu1~<series>.2) for jammy, noble, and resolute on amd64 and arm64. Follows the same shape as the 1.96 bump in #231.Changes
Cargo.toml:rust-version→1.97. The CImsrvjob reads this value, so it now checks on 1.97. The comment now says resolute also takes its toolchain from the rustc-release PPA, since the resolute archive only carries 1.93.debian/control,debian/control.source:Build-Depends→rustc-1.97 | rustc (>= 1.97),cargo-1.97 | cargo (>= 1.97).debian/rules*: preferrustc-1.97/cargo-1.97and raise thedpkg --compare-versionsgate toge 1.97..github/workflows/launchpad_ppa.yml:vendor_rust→1.97.1for all three distros.debian/README.packaging: Rust requirement and PPA notes updated to 1.97.Validation
cargo +1.97.1 check --workspace --lockedpasses.cargo-1.97/rustc-1.97from the rustc-release PPA, vendored withcargo-1.97 vendor --lockedplusdebian/sanitize-vendor.py, and randpkg-buildpackage -bwith the offline--frozenbuild. All three produced the binary packages.Cargo.lockneeds no change.