Repository navigation
test: Expect the span's own trace flags in the storage proxy traceparent test - #16131
Merged
Merged
Conversation
…ent test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
seedspirit
approved these changes
Oct 28, 2026
HyeockJinKim
enabled auto-merge (squash)
October 28, 2026 09:17
HyeockJinKim
disabled auto-merge
October 28, 2026 09:17
This was referenced Oct 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_traceparent_header_follows_the_current_span[True]hardcoded the trace flags as01. Since the OpenTelemetry bump in #16021, the SDK also sets theRANDOM_TRACE_IDflag (0x02), so the header carries03and the test fails. The test now expects the flags of the span it started.Found by the full unit test run of the release PR #16130; the selective CI on
maindid not run this test.Test
pants test tests/unit/manager/clients/test_storage_proxy_client.py🤖 Generated with Claude Code