Skip to content

test: Expect the span's own trace flags in the storage proxy traceparent test - #16131

Merged
HyeockJinKim merged 2 commits into
mainfrom
test/traceparent-trace-flags
Oct 28, 2026
Merged

HyeockJinKim merged 2 commits into
mainfrom
test/traceparent-trace-flags

Conversation

@HyeockJinKim

Copy link
Copy Markdown
Collaborator

Summary

test_traceparent_header_follows_the_current_span[True] hardcoded the trace flags as 01. Since the OpenTelemetry bump in #16021, the SDK also sets the RANDOM_TRACE_ID flag (0x02), so the header carries 03 and the test fails. The test now expects the flags of the span it started.

Found by the full unit test run of the release PR #16130; the selective CI on main did not run this test.

Test

  • pants test tests/unit/manager/clients/test_storage_proxy_client.py

🤖 Generated with Claude Code

…ent test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@HyeockJinKim
HyeockJinKim requested a review from a team as a code owner October 28, 2026 09:16
Copilot AI balanced review requested due to automatic review settings October 28, 2026 09:16
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@HyeockJinKim
HyeockJinKim enabled auto-merge (squash) October 28, 2026 09:17
@HyeockJinKim
HyeockJinKim disabled auto-merge October 28, 2026 09:17
@HyeockJinKim
HyeockJinKim merged commit 60f7346 into main Oct 28, 2026
16 of 17 checks passed
@HyeockJinKim
HyeockJinKim deleted the test/traceparent-trace-flags branch October 28, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants