Repository navigation
feat(BA-8668): identify storage volumes by a system-unique name - #15967
Merged
Merged
Conversation
- Add StorageVolumeName and a unique constraint on storage_volumes.name - Key VolumePool and StorageProxyUnifiedConfig.volume by StorageVolumeName - Use StorageVolumeName as the VfsVolumeStatusCheck identifier; the marker file still holds the UUID volume id - Keep VolumeID lookups only for VolumeService and mark it and its API handler as deprecated Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0128bKAiecc6WfVK9VBRjxBv
github-actions
Bot
added
size:L
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0128bKAiecc6WfVK9VBRjxBv
seedspirit
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StorageVolumeNameand a unique constraint onstorage_volumes.nameVolumePoolandStorageProxyUnifiedConfig.volumebyStorageVolumeName, and use it as theVfsVolumeStatusCheckidentifier; the marker file still holds the UUID volume idVolumeIDlookups only forVolumeService, now marked deprecated together with its API handlerTest plan
tests/unit/storage_proxy/vfolder/test_pool.py: lookup by name, lookup byVolumeID(including an upper-case UUID key), noop volume excluded fromlist_volumes()tests/unit/storage_proxy/vfolder/test_service.py:get_volumes()readslist_volumes_by_id()tests/unit/common/storage/volume/test_vfs.py3b8e1d6c9a47migration and downgrade itResolves BA-8668
🤖 Generated with Claude Code
https://claude.ai/code/session_0128bKAiecc6WfVK9VBRjxBv