Repository navigation
feat(BA-8647): move the default of a dotfile path onto one of the user's dotfiles - #15936
Merged
Merged
Conversation
github-actions
Bot
added
size:L
seedspirit
added a commit
that referenced
this pull request
Oct 21, 2026
seedspirit
marked this pull request as ready for review
October 21, 2026 04:33
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Concurrent switches can fail without retry, and the action does not follow the required field-owner lookup contract.
2 open issues
What changed in this PR
Adds a service operation to select a user's default dotfile variant, preparing for the user dotfile v2 API. No API endpoint calls it yet.
Changes:
- Adds the action, processor, and service method.
- Clears and sets defaults within one scoped transaction.
- Adds database tests and a changelog entry.
| File | Description |
|---|---|
| tests/unit/manager/repositories/user/test_switch_default_dotfile.py | Tests switching, path isolation, and ownership. |
| src/ai/backend/manager/services/user/service.py | Delegates switching to the repository. |
| src/ai/backend/manager/services/user/processors.py | Registers the switch processor. |
| src/ai/backend/manager/services/user/actions/switch_default_dotfile.py | Defines the action and result. |
| src/ai/backend/manager/repositories/user/repository.py | Coordinates transactional default switching. |
| src/ai/backend/manager/models/dotfile/updaters.py | Adds clear-default and set-default specifications. |
| changes/15936.feature.md | Documents the new service operation. |
Review effort: Balanced
Comment on lines
+384
to
+388
| await ops.batch_update_in_scopes( | ||
| scopes, DotfileDefaultClearUpdater(user_id=user_id, dotfile_id=dotfile_id) | ||
| ) | ||
| switched = await ops.batch_update_in_scopes( | ||
| scopes, DotfileDefaultSetUpdater(dotfile_id=dotfile_id) |
Comment on lines
+18
to
+19
| user_id: UserID | ||
| dotfile_id: DotfileID |
fregataa
reviewed
Oct 21, 2026
Comment on lines
+383
to
+388
| # Cleared first; the partial unique index allows one default per path. | ||
| await ops.batch_update_in_scopes( | ||
| scopes, DotfileDefaultClearUpdater(user_id=user_id, dotfile_id=dotfile_id) | ||
| ) | ||
| switched = await ops.batch_update_in_scopes( | ||
| scopes, DotfileDefaultSetUpdater(dotfile_id=dotfile_id) |
Member
There was a problem hiding this comment.
Do we have a bulk updater with conditions?
jopemachine
previously approved these changes
Oct 21, 2026
HyeockJinKim
requested changes
Oct 21, 2026
Comment on lines
+382
to
+388
| async with self._v2_ops.write_ops() as ops: | ||
| # Cleared first; the partial unique index allows one default per path. | ||
| await ops.batch_update_in_scopes( | ||
| scopes, DotfileDefaultClearUpdater(user_id=user_id, dotfile_id=dotfile_id) | ||
| ) | ||
| switched = await ops.batch_update_in_scopes( | ||
| scopes, DotfileDefaultSetUpdater(dotfile_id=dotfile_id) |
Collaborator
There was a problem hiding this comment.
If we handle this without row locks, it seems like it will break.
seedspirit
commented
Oct 21, 2026
Comment on lines
+74
to
+75
| target.entity_type == user_id.entity_type(), | ||
| target.entity_id == user_id, |
Contributor
Author
There was a problem hiding this comment.
In future project and domain migration tasks, we plan to change this from user_id to entity_id.
…r's dotfiles Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Concurrent switches on one path could both clear nothing and then violate uq_dotfiles_is_default. The clear now locks every dotfile of the user on that path in id order, so a concurrent switch waits and re-reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
seedspirit
force-pushed
the
feat/BA-8647
branch
from
October 22, 2026 04:41
b52e25b to
0641e97
Compare
HyeockJinKim
approved these changes
Oct 22, 2026
HyeockJinKim
left a comment
HyeockJinKim
left a comment
Collaborator
There was a problem hiding this comment.
I’d like to generalize the “set default” part, but I think I’ll need to create a separate issue for that. The work you’ve done so far is great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A dotfile is created as a non-default variant, so a path needs an operation that makes one of its variants the one sessions receive. Groundwork for the user dotfile v2 API (BA-8462); no API calls it yet.
SwitchDefaultDotfileAction(user_id, dotfile_id)onUserProcessors, checked against the user likecreate_dotfileUserRepository.switch_default_dotfileruns twoDataBatchUpdaterspecs in onewrite_ops()transaction, both throughbatch_update_in_scopes([UserDotfileTarget(user_id)], ...):DotfileDefaultClearUpdater: clears the default among the user's other dotfiles on the target's path (first, as the partial unique index allows one default per path)DotfileDefaultSetUpdater: sets the target as the defaultDotfileNotFound; the transaction rolls back the clearTest plan
tests/unit/manager/repositories/user/test_switch_default_dotfile.py(real DB)pants lint/pants check --changed-dependents=directResolves BA-8647
🤖 Generated with Claude Code