Repository navigation
feat(BA-8639): let coordinator subapps require the API secret through a middleware - #15906
Closed
jopemachine wants to merge 2 commits into
Closed
jopemachine wants to merge 2 commits into
jopemachine wants to merge 2 commits into
Conversation
jopemachine
added a commit
that referenced
this pull request
Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 20, 2026
… a middleware Move the API secret check out of auth_required into check_api_secret, which auth_required and the new api_secret_auth_middleware both call, so a subapp of api_handler class methods can require the secret on every route. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jopemachine
force-pushed
the
feat/BA-8639-coordinator-secret-middleware
branch
from
October 20, 2026 06:24
0b1fe41 to
ae0e362
Compare
Member
Author
|
#15833 attaches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Stacked PRs
Part of the AppProxy worker Ingress stack (epic BA-8433). Merge in order (bottom-up):
feat(BA-8639): let coordinator subapps require the API secret through a middleware ← you are herefeat(BA-8443): push ingresses from the coordinator to api-delivery workersfeat(BA-8444): export ingresses from the coordinator to Traefik etcdResolves #15905 (BA-8639)
Summary
check_api_secret(request)holds the API secret check thatauth_requireddid inline:X-BackendAI-Token(bare,Bearer,BackendAI) orAuthorization: Bearer <JWT signed with the secret>.auth_requiredcalls it, so the coordinator's existing handlers accept the same tokens as before.auth_required_middlewarecalls it too, so a subapp ofapi_handlerclass methods, whichauth_requiredcannot wrap because their first argument isself, requires the secret on every route. feat(BA-8443): push ingresses from the coordinator to api-delivery workers #15833 uses it for the coordinator/v2/ingressAPI.Test plan
tests/unit/appproxy/coordinator/api/test_utils.py: each accepted token form passes; a missing token, a wrong token, a JWT signed with another secret and an unsupported method are rejected without reaching the handlerpants check/pants testontests/unit/appproxy::🤖 Generated with Claude Code