Skip to content

fix: declare the dotfile concern its field group is wired under - #15899

Merged
HyeockJinKim merged 2 commits into
mainfrom
fix/declare-dotfile-concern
Oct 20, 2026
Merged

HyeockJinKim merged 2 commits into
mainfrom
fix/declare-dotfile-concern

Conversation

@HyeockJinKim

Copy link
Copy Markdown
Collaborator

tests/unit/manager/cli/test_ops.py fails on main, surfaced by the full unit run of the 26.10.0a3 release PR (#15898):

FAILED test_every_wiring_names_a_declared_area - Extra items in the left set: 'dotfile'
FAILED test_a_field_type_hangs_under_the_entity_answering_for_it - Invalid value for '--concern': 'dotfile'

#15666 wires dotfiles through registry.dangling_lookup_field_group, which files the group under the area its field type names (dotfile). Concern declares no such area, so mgr ops list --concern dotfile rejects it. Entity labels are wired the same way and match Concern.ENTITY_LABEL = "label".

Adds Concern.DOTFILE with its description.

Verified

pants test tests/unit/manager/cli/test_ops.py tests/unit/manager/actions:: passes; pants lint check on the file passes.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@HyeockJinKim
HyeockJinKim requested a review from a team as a code owner October 20, 2026 04:57
Copilot AI balanced review requested due to automatic review settings October 20, 2026 04:57
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@HyeockJinKim
HyeockJinKim merged commit b1be8ae into main Oct 20, 2026
40 checks passed
@HyeockJinKim
HyeockJinKim deleted the fix/declare-dotfile-concern branch October 20, 2026 05:07
lablup-octodog added a commit that referenced this pull request Oct 20, 2026
…) (#15900)

Co-authored-by: HyeockJinKim <hyeokjin@lablup.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

The backport to 26.4 hit conflicts: #15901 was created with the conflict markers committed in:

src/ai/backend/manager/actions/registry/types.py

CI on it fails until the markers are resolved; check out its branch, fix, push, and merge it by hand (auto-merge is not enabled for conflicted backports).

@HyeockJinKim

Copy link
Copy Markdown
Collaborator Author

Not backported to 26.4: 26.4 has no ops catalog (actions/registry/, Concern), so the bug does not exist there. Closed #15901.

@fregataa fregataa mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:manager Related to Manager component size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants