feat(BA-8635): choose how the AppProxy worker receives ingresses by jopemachine · Pull Request #15890 · lablup/backend.ai

jopemachine · 2026-10-20T02:07:50Z

📚 Stacked PRs

Part of the AppProxy worker Ingress stack (epic BA-8433). Merge in order (bottom-up):

👉 feat(BA-8635): choose how the AppProxy worker receives ingresses #15890 — feat(BA-8635): choose how the AppProxy worker receives ingresses ← you are here
feat(BA-8443): push ingresses from the coordinator to api-delivery workers #15833 — feat(BA-8443): push ingresses from the coordinator to api-delivery workers

Resolves #15891 (BA-8635)

Summary

New worker config [proxy-worker.ingress] delivery_mode (IngressDeliveryMode) chooses how ingresses are delivered to the worker, as BA-8178 settles: each worker picks its method in its server config and reports it to the coordinator when it starts.
- api: the coordinator sends ingresses to the worker on its API port.
- redis (default): the worker reads what the manager writes to Redis. The default layers becomes ["in-memory", "redis"] to match.
- api requires the in-memory layer and redis the redis layer.
- Circuit events are written into the in-memory state with either delivery, so the existing circuit path keeps working (BA-8437).
The worker adds authority and ingress-delivery-mode labels to its existing service discovery entry, which the coordinator reads in feat(BA-8443): push ingresses from the coordinator to api-delivery workers #15833.
/v2/ingress stays on the existing API port and is now wired to the ingress state. The handler takes IngressStateCtx and IngressConfigCtx, MiddlewareParams that read the ingress state and the ingress config per request, as the storage proxy's StorageRootCtx does. It writes only with the api delivery and answers 501 otherwise. upsert and replace return IngressRevisionsResponse; remove stays 204.

Assumptions

The manager writes every Ingress to Redis whatever the delivery mode (BA-7123). An api-delivery worker with the redis layer then falls back to a complete set: get_all reads the last layer, and a key removed by a push stays removed in Redis.

Constraints from sharing the in-memory state with circuits

A frontend pushed with revision 1 or later fails a later circuit event for the same frontend with 409, since circuit events carry revision 0. Frontends the manager pushes must not overlap the coordinator's circuits.
/v2/ingress/replace replaces the whole state, including the ingresses from circuits. The coordinator in feat(BA-8443): push ingresses from the coordinator to api-delivery workers #15833 calls only upsert and remove.

Test plan

pants check / pants test on tests/unit/appproxy:: and src/ai/backend/appproxy::
tests/unit/appproxy/worker/api/test_ingress.py — writes with the api delivery, 501 otherwise
tests/unit/appproxy/worker/test_config.py — a delivery mode without the layer it needs is rejected

🤖 Generated with Claude Code

[proxy-worker.ingress] mode picks circuit (default, the existing circuit event path), api (the coordinator sends ingresses to the worker) or redis. The worker announces its authority and mode as service discovery labels. /v2/ingress on the API port is wired to the ingress state and writes only in the api mode; upsert and replace return the revisions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…essState IngressState holds the single in-memory writer and the configured mode. The /v2/ingress handler writes only in the api mode and the circuit event path only in the circuit mode, instead of splitting the same writer into api_writer and circuit_writer fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The ingress mode is api or redis, as BA-8178 settles, and defaults to redis with the in-memory and redis layers. Circuit events are written into the ingress state in either mode, so the existing circuit path keeps working while pushes or Redis are added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…f the mode The mode is configuration, not runtime state, so IngressState keeps the IngressConfig it was built from and the /v2/ingress handler reads the mode from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The setting chooses how ingresses are delivered to the worker, so the enum becomes IngressDeliveryMode, the config key delivery and the service discovery label ingress-delivery. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…rom the state IngressState goes back to the reader and writer it holds on main. The /v2/ingress handler takes the ingress config through IngressConfigCtx, next to IngressStateCtx, and reads the delivery from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot

🟡 Changes recommended

Generated local configuration fails validation, and revision reporting can differ from the worker’s effective state.

2 open issues

Report revisions using effective layer precedence · New
Include Redis in local layers example · New

What changed in this PR

Adds configurable ingress delivery for AppProxy workers, preparing them for coordinator pushes in #15833.

Changes:

Adds API/Redis delivery modes and required-layer validation.
Publishes delivery mode and authority through service discovery.
Connects ingress endpoints to worker state and returns applied revisions.

File	Description
tests/unit/appproxy/worker/test_config.py	Tests delivery modes and layer validation.
tests/unit/appproxy/worker/ingress/test_factory.py	Updates factory tests with delivery modes.
tests/unit/appproxy/worker/api/test_ingress.py	Tests revision responses and write restrictions.
src/ai/backend/appproxy/worker/server.py	Adds worker discovery labels.
src/ai/backend/appproxy/worker/dto/context.py	Provides request-scoped state and configuration.
src/ai/backend/appproxy/worker/config.py	Defines delivery settings and validation.
src/ai/backend/appproxy/worker/api/ingress.py	Enables state-backed ingress operations.
src/ai/backend/appproxy/common/types.py	Adds the delivery-mode enum.
src/ai/backend/appproxy/common/defs.py	Defines discovery label constants.
configs/app-proxy-worker/sample.toml	Documents the delivery setting.
changes/15890.feature.md	Records the feature.

_{Review effort: Balanced}

-    async def revisions(self) -> APIResponse:
-        ingresses = await self._require_state().reader.get_all()
+    async def revisions(self, state_ctx: IngressStateCtx) -> APIResponse:
+        ingresses = await state_ctx.ingress_state.reader.get_all()


+                "manager writes to Redis. Circuit events are written in either delivery mode."
+            ),
+            added_version=NEXT_RELEASE_VERSION,
+            example=ConfigExample(local="redis", prod="api"),


jopemachine and others added 2 commits October 20, 2026 11:07

chore: add news fragment for PR #15890

6bba672

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

github-actions Bot assigned jopemachine Oct 20, 2026

github-actions Bot added size:L 100~500 LoC comp:app-proxy Related to App Proxy component labels Oct 20, 2026

jopemachine mentioned this pull request Oct 20, 2026

feat(BA-8443): push ingresses from the coordinator to api-delivery workers #15833

Merged

2 tasks done

jopemachine changed the title ~~feat(BA-8443): choose how the AppProxy worker receives ingresses~~ feat(BA-8635): choose how the AppProxy worker receives ingresses Oct 20, 2026

jopemachine and others added 8 commits October 20, 2026 11:17

chore: update news fragment for PR #15890

dd26870

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore: shorten news fragment for PR #15890

998922b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

refactor(BA-8635): name the ingress config key delivery_mode

50f0059

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(BA-8635): reject a delivery mode without the layer it needs

2eafc6d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

jopemachine marked this pull request as ready for review October 20, 2026 02:54

jopemachine requested a review from a team as a code owner October 20, 2026 02:54

Copilot AI balanced review requested due to automatic review settings October 20, 2026 02:54

Copilot started reviewing on behalf of jopemachine October 20, 2026 02:54

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

HyeockJinKim approved these changes Oct 20, 2026

View reviewed changes

HyeockJinKim merged commit af9afe4 into main Oct 20, 2026
37 checks passed

HyeockJinKim deleted the feat/BA-8443-worker-ingress-mode branch October 20, 2026 03:00

HyeockJinKim mentioned this pull request Oct 20, 2026

release: 26.10.0a3 #15898

Merged

jopemachine mentioned this pull request Oct 20, 2026

feat(BA-8642): add the coordinator client that pushes ingresses to api-delivery workers #15915

Merged

2 tasks done

Navigation Menu

Repository navigation

feat(BA-8635): choose how the AppProxy worker receives ingresses - #15890

feat(BA-8635): choose how the AppProxy worker receives ingresses#15890
HyeockJinKim merged 11 commits into
mainfrom
feat/BA-8443-worker-ingress-mode

jopemachine commented Oct 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jopemachine commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Stacked PRs

Summary

Assumptions

Constraints from sharing the in-memory state with circuits

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jopemachine commented Oct 20, 2026 •

edited

Loading