feat(BA-8504): update the placement policy of a session group by wngh4628 · Pull Request #15747 · lablup/backend.ai

wngh4628 · 2026-10-16T04:47:36Z

Summary

REST v2: PATCH /v2/session-groups/{session_group_id} changes a session group's placement_direction and placement_enforcement.
GraphQL: the updateSessionGroup mutation with UpdateSessionGroupInput and UpdateSessionGroupPayload.
Both call the session group adapter's update, which runs UpdateSessionGroupAction with a SessionGroupUpdater.
An omitted or null field leaves the value unchanged. An input that changes neither field is rejected.

Resolves BA-8504

🤖 Generated with Claude Code

📚 Documentation preview 📚: https://sorna--15747.org.readthedocs.build/en/15747/

📚 Documentation preview 📚: https://sorna-ko--15747.org.readthedocs.build/ko/15747/

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

HyeockJinKim · 2026-10-21T05:59:41Z

+                condition=SessionGroupSearchableFields.linked.replica_groups.not_exists(),
+                error=EntityNotFoundError(
+                    f"Session group {self.group_id} not found",
+                    entity_type=SessionGroupEntityType(),
+                    operation=ActionOperationType.UPDATE,
+                ),


Why does this say "not found"?

Changed it to SessionGroupInUseForUpdate in 5dfedf3.

HyeockJinKim · 2026-10-21T06:00:16Z

+    A group a replica group holds answers not found, as the reads do.
+    """
+
+    group_id: SessionGroupID


If possible, please set the field name to "session_group_id."

Renamed it to session_group_id in 9409047.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

seedspirit · 2026-10-21T07:12:28Z

+        if not isinstance(self.placement_direction, SessionGroupPlacementDirectionEnum) and not (
+            isinstance(self.placement_enforcement, SessionGroupPlacementEnforcementEnum)
+        ):
+            raise ValueError(
+                "UpdateSessionGroupInput requires 'placement_direction' or 'placement_enforcement'"
+            )


Is there a scenario where one side is set to None and the other is left as UNSET?

Yes. For example, {"placement_direction": null} passes null for one field and omits the other.

Both columns are NOT NULL, so the adapter’s OptionalState.from_unset treats null the same as an omitted field: “keep the existing value.”

Since neither field carries a value to change, the validator rejects the request (400 on REST).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fregataa · 2026-10-21T13:00:38Z

+async def update_session_group(
+    info: Info[StrawberryGQLContext],
+    input: UpdateSessionGroupInputGQL,
+) -> UpdateSessionGroupPayloadGQL:


Please set the type nullable (UpdateSessionGroupPayloadGQL | None). The reason is to set nullable response of updateSessionGroup GQL schema

Made both updateSessionGroup and purgeSessionGroup payloads nullable in c90a4ab.

fregataa · 2026-10-21T13:12:41Z

+    @model_validator(mode="after")
+    def _require_a_change(self) -> Self:
+        if not isinstance(self.placement_direction, SessionGroupPlacementDirectionEnum) and not (
+            isinstance(self.placement_enforcement, SessionGroupPlacementEnforcementEnum)
+        ):
+            raise ValueError(
+                "UpdateSessionGroupInput requires 'placement_direction' or 'placement_enforcement'"
+            )


this is okay but we don't need to validate all update input DTOs like this. maybe we can consider of implementing a new generalized update input type

Implementing a new generalized update input type sounds like a good idea. I’ll note it down and work on it in a separate PR when I get the chance.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

… the service and adapter Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…lidator Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…d map Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…rather than not found Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…than a bare group Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…ds nullable Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…phQL inspector Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-authored-by: octodog <mu001@lablup.com>

github-actions Bot assigned wngh4628 Oct 16, 2026

github-actions Bot added size:XL 500~ LoC comp:manager Related to Manager component comp:common Related to Common component area:docs Documentations labels Oct 16, 2026

wngh4628 added a commit that referenced this pull request Oct 16, 2026

changelog: add news fragment for PR #15747

69336cb

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wngh4628 force-pushed the feature/BA-8500-session-group-api branch from 597bc6f to 5c270d0 Compare October 16, 2026 06:13

Base automatically changed from feature/BA-8500-session-group-api to main October 16, 2026 16:35

wngh4628 added a commit that referenced this pull request Oct 21, 2026

changelog: add news fragment for PR #15747

6322cab

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wngh4628 force-pushed the feature/BA-8504-update-session-group branch from 69336cb to 6322cab Compare October 21, 2026 05:47

wngh4628 marked this pull request as ready for review October 21, 2026 05:53

wngh4628 requested a review from a team as a code owner October 21, 2026 05:53

HyeockJinKim reviewed Oct 21, 2026

View reviewed changes

wngh4628 added a commit that referenced this pull request Oct 21, 2026

changelog: add news fragment for PR #15747

2de4e16

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wngh4628 force-pushed the feature/BA-8504-update-session-group branch from 3605c4c to 9409047 Compare October 21, 2026 06:26

seedspirit reviewed Oct 21, 2026

View reviewed changes

wngh4628 added a commit that referenced this pull request Oct 21, 2026

changelog: add news fragment for PR #15747

18d96af

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wngh4628 force-pushed the feature/BA-8504-update-session-group branch from 518181a to 865640e Compare October 21, 2026 07:23

wngh4628 requested review from HyeockJinKim and seedspirit October 21, 2026 07:24

fregataa reviewed Oct 21, 2026

View reviewed changes

seedspirit previously approved these changes Oct 22, 2026

View reviewed changes

wngh4628 and others added 7 commits October 22, 2026 10:56

feat(BA-8504): add the session group update input and payload

9bd2e7e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(BA-8504): update the placement policy of a session group through…

bffacda

… the service and adapter Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(BA-8504): add the REST v2 session group update

657c661

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(BA-8504): add the updateSessionGroup GraphQL mutation

8a8baf2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(BA-8504): raise ValueError from the session group update input va…

f8ff375

…lidator Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

refactor(BA-8504): build the session group updater with from_unset an…

5fc9b73

…d map Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

changelog: add news fragment for PR #15747

904267e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wngh4628 and others added 6 commits October 22, 2026 10:56

fix(BA-8504): refuse updating a deployment's session group as in use …

7f6864e

…rather than not found Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

refactor(BA-8504): name the session group id fields session_group_id

f1b43ed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(BA-8504): name the session group in the update scenarios rather …

71acb76

…than a bare group Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(BA-8504): fail the update success scenarios on any missing answer

df45009

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(BA-8504): make the session group update and purge mutation payloa…

28bf4e4

…ds nullable Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

ci(BA-8504): accept the nullable purgeSessionGroup payload in the Gra…

dd24c4e

…phQL inspector Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wngh4628 dismissed seedspirit’s stale review via dd24c4e October 22, 2026 01:58

wngh4628 force-pushed the feature/BA-8504-update-session-group branch from b607ef7 to dd24c4e Compare October 22, 2026 01:58

chore: update api schema dump

7dd4dca

Co-authored-by: octodog <mu001@lablup.com>

seedspirit approved these changes Oct 22, 2026

View reviewed changes

fregataa approved these changes Oct 22, 2026

View reviewed changes

fregataa merged commit 0bc3454 into main Oct 22, 2026
40 checks passed

fregataa deleted the feature/BA-8504-update-session-group branch October 22, 2026 07:13

Navigation Menu

Repository navigation

feat(BA-8504): update the placement policy of a session group - #15747

feat(BA-8504): update the placement policy of a session group#15747
fregataa merged 14 commits into
mainfrom
feature/BA-8504-update-session-group

wngh4628 commented Oct 16, 2026 •

edited by github-actions Bot

Loading

Uh oh!

HyeockJinKim Oct 21, 2026

Uh oh!

wngh4628 Oct 21, 2026

Uh oh!

HyeockJinKim Oct 21, 2026

Uh oh!

wngh4628 Oct 21, 2026

Uh oh!

seedspirit Oct 21, 2026

Uh oh!

wngh4628 Oct 21, 2026

Uh oh!

fregataa Oct 21, 2026

Uh oh!

wngh4628 Oct 22, 2026

Uh oh!

fregataa Oct 21, 2026

Uh oh!

wngh4628 Oct 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wngh4628 commented Oct 16, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wngh4628 Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wngh4628 commented Oct 16, 2026 •

edited by github-actions Bot

Loading

wngh4628 Oct 22, 2026 •

edited

Loading