Repository navigation
ci: Run CodeQL from a workflow that skips test code - #15166
Closed
HyeockJinKim wants to merge 1 commit into
Closed
HyeockJinKim wants to merge 1 commit into
HyeockJinKim wants to merge 1 commit into
Conversation
CodeQL default setup has no path filter, so test code is analyzed and reported. Move the analysis to a workflow with the same languages, build modes and categories, and ignore tests/ and src/ai/backend/test/. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflow, pinned CodeQL version, categories, and path exclusions are consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Moves CodeQL to advanced setup so Python test paths are excluded while preserving existing analysis categories.
Changes:
- Adds scheduled, push, and PR CodeQL analysis for Actions, Go, and Python.
- Adds test-path exclusions matching DevSkim.
| File | Description |
|---|---|
.github/workflows/codeql.yml |
Defines the advanced CodeQL workflow. |
.github/codeql/codeql-config.yml |
Excludes test directories from analysis. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
Closing: keep CodeQL default setup; test-code alerts will be dismissed as 'used in tests' instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py/incomplete-url-substring-sanitization)..github/workflows/codeql.ymlwith.github/codeql/codeql-config.ymlignoringtests/**andsrc/ai/backend/test/**, the same paths DevSkim skips./language:actions/language:go/language:pythongithub/codeql-actionis pinned to v4.38.2 (2892aa5).Merge note
Code scanning rejects analyses from a workflow while default setup is enabled, so the
CodeQLjobs on this PR are expected to fail at upload. Disable default setup when merging (Settings → Code security → CodeQL analysis → Switch to advanced, orgh api -X PATCH repos/lablup/backend.ai/code-scanning/default-setup -f state=not-configured).🤖 Generated with Claude Code