Repository navigation
feat(nav): walkDistancesFrom — reuse the resolved origin across a destination scan (4.2.0) - #61
Merged
Merged
Conversation
Minor: a new query (`Controller.walkDistancesFrom` / `WalkDistances`) for synchronous destination scans; no behaviour change for existing callers. Claude-Session: https://claude.ai/code/session_01LpszrcSrLLijQcxxvgWyUQ
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Controller.walkDistancesFrom(game, origin)returns aWalkDistancesquery whoseto(target)reuses the origin's world position and validated nearest node across a synchronous, read-only candidate scan. Same semantics aswalkDistanceon every path: pre-graph Euclidean, off-graph origin → ∞ without touching the target's cache entry, targets resolved live through the position-validatednearest_node_cache. Documented as scan-scoped (discard before the origin or its ancestors move, the graph changes, or the frame advances); not a cross-frame cache.Consumer: Flying Platform's
findEmptyStorageDestinationFiltered(one origin, ~300 accepting slots per scan) — companion FP PR follows once this is released. Version bumped to 4.2.0 (minor: new query, no behaviour change).Measured (Flying Platform
big_colony, Android emulator, ReleaseFast, per-frame probes; same tree on 4.1.0 vs this branch via a local override, no tracer running)production_flushp95 / p99 / maxThe saving scales with queries per scan (the per-candidate origin resolution it removes); scans with few queries are unchanged. Investigation thread: moca-tecnologia/flying-platform-labelle#1042 (last comment).
Validation
zig build test: 13/13 incl. the two newWalkOrigintests (Euclidean fallback, graph unreachable, refresh after movement and graph rebuild).https://claude.ai/code/session_01LpszrcSrLLijQcxxvgWyUQ