Repository navigation
release: labelle-engine v4.0.0 — no platform code in the engine (#902) - #914
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe engine package version in ChangesPackage version
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change only updates the package version to 3.6.0 and shows no concrete merge risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Title checkExplanation The title describes a release and the removal of platform code, but the changeset only updates the engine package from 3.5.1 to 3.6.0. It also states version 4.0.0, which conflicts with the recorded objective of releasing 3.6.0.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e41b1af6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .fingerprint = 0xe8a81a8dc7f48c87, | ||
| .name = .engine, | ||
| .version = "3.5.1", | ||
| .version = "3.6.0", |
There was a problem hiding this comment.
Publish the API removal under a new major version
This release removes the public engine.android export in src/root.zig, and the release notes acknowledge that existing generated code can now hit a compile error, so publishing it as 3.6.0 violates the repository's major-version compatibility boundary. Consumers accepting compatible 3.x upgrades—or directly calling engine.android.enableImmersiveMode—can therefore receive a non-compiling update; this release needs a new major version rather than a minor bump.
Useful? React with 👍 / 👎.
Major: engine.android (a public export) is removed, and storage.Default's Android path is replaced by a caller-supplied platform_root.
7e41b1a to
33d336b
Compare
Bumps to 4.0.0 for #904, which closes #902: the engine carries no platform code. It is a major release because a public export is removed. Per review, this follows the semver boundary rather than shipping as 3.6.0.
Breaking
engine.androidis gone. Immersive mode lives in labelle-android 0.3.0+ (immersive), and assembler 0.119.0+ calls it through theandroidplugin. Code generated by an older assembler, or a project with immersive mode but noandroidplugin, gets a@compileErrornaming the fix: add theandroidplugin, labelle-android >= 0.3.0.storage.dataRoot: the.androidplatform andandroid_internalare replaced by a caller-suppliedplatform_root(storage.Default.Options.platform_root).storage.Defaulthas no production caller in the toolkit today.Also
preview_shmgates on a build-providedtarget_features.has_posix_shm.Compatibility
Neither the CLI nor the assembler hard-checks the engine's major: a pin above the CLI's curated engine line doesn't even warn, so existing 3.x pins keep working until a project bumps.
Verified: on-device immersive acceptance passed on a P42 and the SM-T505 (Trello card, #904), with FP on labelle-android 0.3.0 and assembler 0.121.0.