Skip to content

release: labelle-engine v4.0.0 — no platform code in the engine (#902) - #914

Merged
apotema merged 1 commit into
mainfrom
release/v3.6.0
Oct 1, 2026
Merged

apotema merged 1 commit into
mainfrom
release/v3.6.0

Conversation

@apotema

@apotema apotema commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Bumps to 4.0.0 for #904, which closes #902: the engine carries no platform code. It is a major release because a public export is removed. Per review, this follows the semver boundary rather than shipping as 3.6.0.

Breaking

  • engine.android is gone. Immersive mode lives in labelle-android 0.3.0+ (immersive), and assembler 0.119.0+ calls it through the android plugin. Code generated by an older assembler, or a project with immersive mode but no android plugin, gets a @compileError naming the fix: add the android plugin, labelle-android >= 0.3.0.
  • storage.dataRoot: the .android platform and android_internal are replaced by a caller-supplied platform_root (storage.Default.Options.platform_root). storage.Default has no production caller in the toolkit today.

Also

  • preview_shm gates on a build-provided target_features.has_posix_shm.
  • The agnostic guard drops four files.

Compatibility

Neither the CLI nor the assembler hard-checks the engine's major: a pin above the CLI's curated engine line doesn't even warn, so existing 3.x pins keep working until a project bumps.

Verified: on-device immersive acceptance passed on a P42 and the SM-T505 (Trello card, #904), with FP on labelle-android 0.3.0 and assembler 0.121.0.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T12:04:11.363535Z 33d336b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: e16e21e7-a762-4847-8ab8-ca5b87f31fc3

📥 Commits

Reviewing files that changed from the base of the PR and between 30e61a3 and 7e41b1a.

📒 Files selected for processing (1)
  • build.zig.zon

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The engine package version in build.zig.zon changes from 3.5.1 to 3.6.0.

Changes

Package version

Layer / File(s) Summary
Package version metadata
build.zig.zon
The engine package version changes from 3.5.1 to 3.6.0.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: leonardomag31-lab

Merge Risk: ⚪ Minimal · up to 7e41b

This change only updates the package version to 3.6.0 and shows no concrete merge risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes a release and the removal of platform code, but the changeset only updates the engine package from 3.5.1 to 3.6.0. It also states version 4.0.0, which conflicts with the recorded o… Update the title to match the actual release version and changeset, for example: "release: labelle-engine v3.6.0" or include the platform-code removal only if those changes are present in the pull request.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue #902 is the active directly linked issue. The PR summary reports the required coding changes: immersive mode moved to labelle-android, preview_shm uses target_features.has_posix_shm, and `st…
Out of Scope Changes check ✅ Passed The reviewed change updates the engine package version from 3.5.1 to 3.6.0. This change supports the release of the platform-agnostic engine work described by issue #902. No unrelated source, test, or…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Description check ✅ Passed The description discusses the engine release, removal of platform-specific code, Android API changes, and compatibility. These topics are related to the stated pull request objectives and release chan…
Full details: Title check

Explanation

The title describes a release and the removal of platform code, but the changeset only updates the engine package from 3.5.1 to 3.6.0. It also states version 4.0.0, which conflicts with the recorded objective of releasing 3.6.0.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e41b1af6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread build.zig.zon Outdated
.fingerprint = 0xe8a81a8dc7f48c87,
.name = .engine,
.version = "3.5.1",
.version = "3.6.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Publish the API removal under a new major version

This release removes the public engine.android export in src/root.zig, and the release notes acknowledge that existing generated code can now hit a compile error, so publishing it as 3.6.0 violates the repository's major-version compatibility boundary. Consumers accepting compatible 3.x upgrades—or directly calling engine.android.enableImmersiveMode—can therefore receive a non-compiling update; this release needs a new major version rather than a minor bump.

Useful? React with 👍 / 👎.

Major: engine.android (a public export) is removed, and storage.Default's
Android path is replaced by a caller-supplied platform_root.
@apotema apotema changed the title release: labelle-engine v3.6.0 — no platform code in the engine (#902) release: labelle-engine v4.0.0 — no platform code in the engine (#902) Oct 1, 2026
@apotema
apotema merged commit 048b17c into main Oct 1, 2026
3 checks passed
@apotema
apotema deleted the release/v3.6.0 branch October 1, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the engine platform-agnostic (after the CLI full-agnostic phase, cli#471)

2 participants