Repository navigation
docs(rfc-i18n): LABELLE_LOCALE takes an exact tag, not the device-language matching - #911
Merged
Merged
Conversation
…guage matching Since labelle-assembler 8faf2c1 (#753) the env override only accepts an exact shipped tag; the language fallback is for the device language. §8 still said LABELLE_LOCALE went through the same matching. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Comment |
apotema
approved these changes
Oct 12, 2026
apotema
left a comment
apotema
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the RFC correction against the generated i18n implementation. LABELLE_LOCALE uses setLocale and accepts a shipped tag (case-insensitive); device-language detection alone uses matchLocale and its language fallback. No findings. Ubuntu and Windows CI passed. This documentation-only change needs no additional runtime tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix to RFC-I18N §8, item 3. Since labelle-assembler
8faf2c1(labelle-assembler#753),LABELLE_LOCALEonly accepts an exact shipped tag (the generatedensureEnvLocalecallssetLocale(raw)). ThematchLocalelanguage fallback is for the device language only. The RFC still said the env var "goes through the same matching".Flagged by Alexandre in the #917 handoff (Flying-Platform card frgjL7Nk).
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.