Repository navigation
release: labelle-android v0.4.0 — Vulkan renderer selection, crash guard, activity finish - #37
Conversation
…ard, activity finish Minor release for labelle-bgfx#172 (Android Vulkan) and FP#979 (Android Exit): - "renderer" provider setting + labelle.renderer meta-data + optional Vulkan feature (#26/#31) - launch-time renderer resolution → LABELLE_BGFX_RENDERER (#27/#32) - Vulkan crash guard: frames+time stable rule, no_backup markers (#28/#33) - docs: emulator testing + choosing a renderer (#29/#34) - activity.finish(): game.quit() closes the app on Android (#35) docs/renderer.md now names 0.4.0. Claude-Session: https://claude.ai/code/session_01LpszrcSrLLijQcxxvgWyUQ
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe package version changed from 0.3.1 to 0.4.0. The renderer documentation now identifies 0.4.0 as the minimum version that reads ChangesRelease Version
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The package version and renderer documentation agree on 0.4.0. These reviewed changes show no concrete release risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
VERDICT: APPROVED Codex, OpenAI LLM. Reviewed exact Independent Windows |
Minor release (0.3.1 → 0.4.0).
build.zig.zon.versionbump, plusdocs/renderer.mdnaming 0.4.0.zig build test --summary allexit 0.Contents since 0.3.1:
"renderer"provider setting (gles/vulkan/auto, defaultgles), thelabelle.renderermeta-data and the optional Vulkan 1.1uses-feature(Android Vulkan (labelle-bgfx#172) P4a: "renderer" provider setting + manifest meta-data and Vulkan feature #26, PR feat: "renderer" provider setting + manifest meta-data and Vulkan feature (#26) #31)LABELLE_BGFX_RENDERER, before bgfx init (Android Vulkan (labelle-bgfx#172) P4b: resolve the renderer at launch and export LABELLE_BGFX_RENDERER #27, PR Resolve the renderer at launch and export LABELLE_BGFX_RENDERER (#27) #32)labelle_bgfx_frames_presented, labelle-bgfx ≥ the release with #183) and ≥10 s,no_backupmarkers, fail-closed (Android Vulkan (labelle-bgfx#172) P4c: crash guard: fall back to GLES after a crashed Vulkan start #28, PR feat: Vulkan crash guard — GLES after a crashed Vulkan start (#28) #33)activity.finish():game.quit()finishes the Activity on Android (feat(activity): finish the activity when the game quits (FP#979) #35), for labelle-bgfx#186 / FP#979After merge: tag
v0.4.0, GitHub release, and the labelle-registryproviders.jsonentry (commit + sha256 of the commit tarball; 0.3.0's missing entry broke FP CI before). Then re-pin labelle-bgfx#186.Part of labelle-toolkit/labelle-bgfx#172.
https://claude.ai/code/session_01LpszrcSrLLijQcxxvgWyUQ
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.