Repository navigation
feat: initial project scaffold; kubebuilder init - #3
Conversation
|
|
dushanpantic
left a comment
dushanpantic
left a comment
There was a problem hiding this comment.
A lot of template stuff that is perhaps unnecessary for this module.
See gpu-driver for inspiration
| "ghcr.io/devcontainers/features/docker-in-docker:2": { | ||
| "moby": false, | ||
| "dockerDefaultAddressPool": "base=172.30.0.0/16,size=24" | ||
| }, |
There was a problem hiding this comment.
delete devcontainers setup, I dont think it will be used
There was a problem hiding this comment.
kubebuilder scaffold
removing
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Clone the code | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
action version should be whatever is latest v6 (check)
| name: E2E Tests | ||
|
|
There was a problem hiding this comment.
kubebuilder scaffold
removing
| # This patch adds the args, volumes, and ports to allow the manager to use the metrics-server certs. | ||
|
|
||
| # Add the volumeMount for the metrics-server certs |
There was a problem hiding this comment.
kubebuilder scaffold, also exists in gpu-driver.
needed if we enable tls certs for metrics via cert-manager.
| # Labels to add to all resources and selectors. | ||
| #labels: | ||
| #- includeSelectors: true |
There was a problem hiding this comment.
do we need some commonLabels here?
There was a problem hiding this comment.
gpu-driver doesnt have them.
lets leave it like this for now and add later if needed.
| value: | ||
| # SERVICE_NAME and SERVICE_NAMESPACE will be substituted by kustomize | ||
| serverName: SERVICE_NAME.SERVICE_NAMESPACE.svc | ||
| insecureSkipVerify: false | ||
| ca: |
There was a problem hiding this comment.
kubebuilder scaffold. not used for now, also exists in gpu-driver. would leave entire prometheus directory.
| - metrics_auth_role.yaml | ||
| - metrics_auth_role_binding.yaml | ||
| - metrics_reader_role.yaml |
There was a problem hiding this comment.
if we remove metrics, do we need this?
There was a problem hiding this comment.
scaffold. still need this file, but commenting out these three lines since not needed at this point, aligning it with gpu-driver
| package e2e | ||
|
|
There was a problem hiding this comment.
scaffold, removing. will bring back when we get to e2e stage
| package e2e | ||
|
|
||
| import ( | ||
| "encoding/json" |
There was a problem hiding this comment.
scaffold, removing. will bring back when we get to e2e stage
| .vscode | ||
| *.swp | ||
| *.swo | ||
| *~ |
There was a problem hiding this comment.
removed ds_store
added to .gitignore
Description
Changes proposed in this pull request:
Related issue(s)
Project scaffold