Feature/rescan and ux changes - #77
Open
atendev wants to merge 3 commits into
Open
Conversation
…anges - Switch author-color scanning to manual. Used to run on each keystroke which added a lot of names to the list when author-colors was switched on. Now you simply input authors, click rescan, and then it scans everywhere. - Add "Available Authors" as a comma separated list of authors for you to choose from when making a new comment. For those who want to be able to choose between multiple comment authors while also keeping a single data file. - Add trash remove icon for uncolored authors to fully remove them from the list as there was no way to do so previously. - Add author selector into the comment creation modal. - Separate highlights from comments being shown. Now highlights can still be active even if in-line comments are not shown. - Add "Show Highlights" and "Highlights Open Sidebar" settings. When clicking on a highlight and comments are hidden, will open the sidebar to the comment in question while still allowing to edit the text as normal. - Move the main action bar up to the corner of the modal since it could get in the way of text on smaller screens. - Make border of the add-comment modal the color of the selcted author for better UX. - Add "Add Comment" button to the context window when right clicking selected text. - Update tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was changing things for my own vault since i encountered some bugs and such, so i went ahead and compiled it all. Sorry its a lot of changes at once. By the time i was done I realized I never committed any of it and they all used the same files.
Great job on the plugin though, it looks great! Both the code and the UX.
Changes