Repository navigation
Say sessions processed, not uploaded, in the import status #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
realtonyyoung
merged 5 commits into
main
from
claude-tyoung/session-import-message-wording-732077
Oct 23, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6cb0704
Say sessions processed, not uploaded, in the import status (#1885)
realtonyyoung 29bf0c1
Count processed sessions and say import in local onboarding copy (#1885)
realtonyyoung 32fc686
Settle the processed count from the import totals line (#1885)
realtonyyoung b1e9e5c
Merge remote-tracking branch 'origin/main' into claude-tyoung/session…
realtonyyoung 06a14dc
Expect both import passes' totals in the processed count (#1885)
realtonyyoung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| using Capacitor.App.Services; | ||
| using Capacitor.App.ViewModels.Onboarding; | ||
| using Capacitor.Cli.Core; | ||
|
|
||
| namespace Capacitor.App.Tests.Unit; | ||
|
|
||
| public class HistoryImportRunTests { | ||
| /// The totals line also counts sessions that never printed a line of their own, so it settles the | ||
| /// processed count without counting the printed ones twice. | ||
| [Test] | ||
| public async Task The_totals_line_settles_the_processed_count() { | ||
| var cli = new FakeKcapCli { | ||
| ImportBehavior = (_, onLine, _) => { | ||
| onLine(new StreamedLine(ProcessStreamKind.Stdout, " Loading s1 (claude)")); | ||
| onLine(new StreamedLine(ProcessStreamKind.Stdout, " Loading s2 (claude)")); | ||
| onLine(new StreamedLine(ProcessStreamKind.Stdout, " Skipping k1 (already current)")); | ||
| onLine(new StreamedLine(ProcessStreamKind.Stdout, " 5 imported · 2 skipped · 1 failed")); | ||
| return Task.FromResult(new StreamingResult(0, false, [])); | ||
| }, | ||
| }; | ||
| var run = new HistoryImportRun(0, 1, "from the last 90 days", 1, action => action()); | ||
| run.Start(cli, [new ImportRequest(ImportScopeChoice.Repo, null, [], ["a/b"])]); | ||
| await run.Completion; | ||
|
|
||
| await Assert.That(run.Processed).IsEqualTo(8); | ||
| await Assert.That(run.Imported).IsEqualTo(5); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.