[nortonandreev]

Closes #1856 — AI-4266

What & why

The harness step showed "Current setting: …" while no radio option was selected. The radio group is the control, so it is now the only place the choice is shown, including before one is picked. The view-model state that only fed the line is removed; the step still reads the saved profile on entry for the provider-key answer.

Verification

dotnet run --project test/Capacitor.App.Tests.Unit: 4,240 passed, 10 skipped, 0 failed. Headless renders with the app's styles:

	Before	After
Nothing selected
Selected

[linear-code]

AI-4266

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: e17cf68c-3788-4829-8d24-75a96e588ae8

📥 Commits

Reviewing files that changed from the base of the PR and between d1f1dc3 and 8834b9b.

📒 Files selected for processing: 3

• src/Capacitor.App/ViewModels/Onboarding/HarnessesStepViewModel.cs
• src/Capacitor.App/Views/Onboarding/HarnessesPaneView.axaml
• test/Capacitor.App.Tests.Unit/HarnessesStepViewModelTests.cs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[qodo-code-review]

PR Summary by Qodo

Remove the redundant current-setting line from harness onboarding

🐞 Bug fix 🕐 10-20 Minutes

AI Description

• Remove the current-setting line so the privacy radio group is the only place the choice appears.
• Keep privacy unselected on entry while still loading the saved provider-key answer.
• Adjust the profile-saving test to stop asserting the removed note.

Diagram

graph TD
    U["User"] --> R["Privacy radio group"] --> V["Harness step model"] --> P["Active profile"]
    P -->|"provider key answer"| V

Loading

High-Level Assessment

Removing the redundant line and its view-model state is the simplest approach. Keeping a separate readout would preserve the mismatch between displayed settings and the unselected radio group.

Files changed (3) +3 / -18

Bug fix (2) +1 / -14

HarnessesStepViewModel.csRemove derived current-visibility note +1/-12

Remove derived current-visibility note

• Removes the note property and its updates when loading or saving a profile. Profile loading still restores the provider-key answer without preselecting visibility.

src/Capacitor.App/ViewModels/Onboarding/HarnessesStepViewModel.cs

HarnessesPaneView.axamlRemove the current-setting text from the privacy card +0/-2

Remove the current-setting text from the privacy card

• Removes the text block bound to the current-visibility note, leaving the radio group as the sole display of the privacy choice.

src/Capacitor.App/Views/Onboarding/HarnessesPaneView.axaml

Tests (1) +2 / -4

HarnessesStepViewModelTests.csDrop assertions for the removed visibility note +2/-4

Drop assertions for the removed visibility note

• Keeps the test's checks for an initially unselected privacy choice, the loaded provider-key answer, and both values saved to the profile.

test/Capacitor.App.Tests.Unit/HarnessesStepViewModelTests.cs

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[nortonandreev]

@CodeRabbit approve

[coderabbitai]

✅ Action performed

Comments resolved and changes approved.